Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitbucket Cloud Support as source #450

Merged
merged 6 commits into from
Sep 29, 2020
Merged

Conversation

Doctor-X
Copy link
Contributor

In my project, we needed to source the migrations from Bitbucket Cloud.
Implemented the source Driver interface for Bitbucket Cloud, let me know if this can be merged into the codebase.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 873

  • 3 of 146 (2.05%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.4%) to 52.844%

Changes Missing Coverage Covered Lines Changed/Added Lines %
source/bitbucket/bitbucket.go 3 146 2.05%
Totals Coverage Status
Change from base Build 871: -1.4%
Covered Lines: 2871
Relevant Lines: 5433

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 27, 2020

Pull Request Test Coverage Report for Build 876

  • 3 of 141 (2.13%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.4%) to 52.892%

Changes Missing Coverage Covered Lines Changed/Added Lines %
source/bitbucket/bitbucket.go 3 141 2.13%
Totals Coverage Status
Change from base Build 871: -1.4%
Covered Lines: 2871
Relevant Lines: 5428

💛 - Coveralls

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!


b := &Bitbucket{}

d, err := b.Open("bitbucket://" + BitbucketTestSecret + "@abhishekbipp/test-migration/migrations/test#master")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup a public repo to test against

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
bi.config.Ref = u.Fragment

if err := bi.readDirectory(); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call WithInstance() so there's a single path to instantiate a Bitbucket struct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants