Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move -all flag usage from drop to down #522

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Move -all flag usage from drop to down #522

merged 1 commit into from
Mar 14, 2021

Conversation

Juneezee
Copy link
Contributor

The -all flag still exists for drop usage, even though the drop subcommand no longer accepts -all anymore.

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The drop command still accepts the -all parameter

@Juneezee
Copy link
Contributor Author

@dhui Using migrate v4.14.1, doing the following command

$ migrate -database 'postgresql://postgres:postgres@localhost:5432/db?sslmode=disable' -path migrations/ drop -all

returns the following output

flag provided but not defined: -all
Usage of drop:
  -f	Force the drop command by bypassing the confirmation prompt
  -help
    	Print help informatio

Looking at the source code for drop, it doesn't seem to accept -all flag anymore(?)

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry! For some reason I confused down and drop...

internal/cli/main.go Outdated Show resolved Hide resolved
@Juneezee Juneezee changed the title Remove -all from drop subcommand usage Move -all flag usage from drop to down Mar 13, 2021
@Juneezee Juneezee requested a review from dhui March 13, 2021 07:06
internal/cli/main.go Outdated Show resolved Hide resolved
The `-all` flag usage should be used in `down` only, not `drop`.

Signed-off-by: Eng Zer Jun <[email protected]>
@Juneezee Juneezee requested a review from dhui March 13, 2021 07:23
@dhui dhui merged commit 707fc52 into golang-migrate:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants