Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point docs link to v4 #524

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Point docs link to v4 #524

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03bd32b
Point docs link to `v4`
jeffwidman Mar 13, 2021
d19511f
Update the badge link as well
jeffwidman Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[![CircleCI - Build Status](https://img.shields.io/circleci/build/github/golang-migrate/migrate/master)](https://circleci.com/gh/golang-migrate/migrate)
[![GoDoc](https://godoc.org/github.com/golang-migrate/migrate?status.svg)](https://godoc.org/github.com/golang-migrate/migrate)
[![GoDoc](https://godoc.org/github.com/golang-migrate/migrate?status.svg)](https://pkg.go.dev/github.com/golang-migrate/migrate/v4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the image link

Copy link
Contributor Author

@jeffwidman jeffwidman Mar 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't realize they now exposed those directly... updated! I used the Github web UI which doesn't allow squashing, so please squash on merge.

I dropped the ?status.svg as it appears to work fine without that, but if you want me to put it back let me know.

I also wasn't sure if I needed to append /v4 to the end of the image URL... it looks the same both ways, so I thought simpler to leave w/o so that if there's ever a v5 only the actual link needs updating, not the image link.

[![Coverage Status](https://img.shields.io/coveralls/github/golang-migrate/migrate/master.svg)](https://coveralls.io/github/golang-migrate/migrate?branch=master)
[![packagecloud.io](https://img.shields.io/badge/deb-packagecloud.io-844fec.svg)](https://packagecloud.io/golang-migrate/migrate?filter=debs)
[![Docker Pulls](https://img.shields.io/docker/pulls/migrate/migrate.svg)](https://hub.docker.com/r/migrate/migrate/)
Expand Down