-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a method to create a mysql database from a connection object #583
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to
WithConnection()
and useconn.PingContext()
.DB.Ping()
will create a connection to ping anywaysThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem I am trying to solve is that this class does unexpected stuff to my connection pool.
If I inject an active pool with
n
idle connections to this class, do my stuff and close it, I expect my pool to be returned to it's initial state, which means an active pool withn
idle connections.But currently I can only choose between ending-up with a closed pool (because
Close
not only returns the connection to the pool, but also closes the pool itself), or (if I don't callClose
) a pool withn-1
idle connections and1
allocated connection that will be stuck foreverSo the last thing I want is for
WithConnection
to create new connections in a pool that I did not even inject in the first place.If the connection I inject is not working, I expect the process to fail without side-effects on my pool.
If the connection is not working, doing
conn.PingContext().DB.Ping()
would create a new connection in the pool and ping the new connection, which does not test or fix the injected one anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that connections are pooled at the
sql.DB
instance level soconn.PingContext()
shouldn't create a new connection e.g. connections won't create new connectionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was misunderstanding your question.
I added the context to
WithConnection
, as well as callingPingContext
.I cannot add it as a parameter in
WithInstance
without breaking change, so it should be done along with #14.