Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use github.com/cockroachdb/cockroach-go/v2/crdb #595

Merged
merged 3 commits into from
Jul 27, 2021
Merged

use github.com/cockroachdb/cockroach-go/v2/crdb #595

merged 3 commits into from
Jul 27, 2021

Conversation

DGollings
Copy link
Contributor

In my case, for better go module support using a goproxy

Although github.com/cockroachdb/cockroach-go itself mentions to use /v2 and tests still pass. Seems to be a very minor change

@DGollings
Copy link
Contributor Author

noticed #424 and ran go mod tidy, seems that whatever was the issue then has been resolved?

@coveralls
Copy link

coveralls commented Jul 14, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 503

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.369%
Totals Coverage Status
Change from base Build 502: 0.0%
Covered Lines: 3624
Relevant Lines: 6317
💛 - Coveralls

@dhui dhui mentioned this pull request Jul 27, 2021
Closed
@dhui dhui merged commit 586cc86 into golang-migrate:master Jul 27, 2021
@dhui
Copy link
Member

dhui commented Jul 27, 2021

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DGollings @coveralls @dhui