Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to microsoft go-mssqldb #758

Merged

Conversation

jonkjenn
Copy link
Contributor

@jonkjenn jonkjenn commented Jun 29, 2022

The Microsoft fork is more up to date with the Azure SDK and it seems like this will be the maintained version going forward denisenkom/go-mssqldb#729

@coveralls
Copy link

coveralls commented Jun 29, 2022

Coverage Status

Coverage remained the same at 57.807% when pulling 3d7b73d on jonkjenn:Switch_to_microsoft_go-mssqldb_fork into eebc4c4 on golang-migrate:master.

@jonkjenn jonkjenn marked this pull request as ready for review June 29, 2022 08:52
dhui
dhui previously approved these changes Jul 27, 2022
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this to our attention and for creating a PR!

@dhui
Copy link
Member

dhui commented Jul 27, 2022

Can you resolve the merge conflicts?

@jonkjenn jonkjenn requested a review from dhui July 27, 2022 08:25
@dhui dhui merged commit 0d585e2 into golang-migrate:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants