Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue of downloading and using github sourced migration files of … #900

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

gfcroft
Copy link
Contributor

@gfcroft gfcroft commented Mar 23, 2023

fix issue of downloading and using github sourced migration files of 100MB >=1Mb (which previously failed to download due to their size and the api call performed) by preferring the go-github client library method 'DownloadContents' for such operations (which doesn't have the same limitation)

…100MB >=1Mb (which previously failed to download due to their size and the api call performed) by preferring the go-github client library method 'DownloadContents' for such operations (which doesn't have the same limitation)
@coveralls
Copy link

Coverage Status

Coverage: 58.038%. Remained the same when pulling 021a9c1 on georgewheatcroft:master into 8ec0422 on golang-migrate:master.

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this issue!

@dhui dhui merged commit b63a0d4 into golang-migrate:master Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-migrate fails on large github sourced migration files
3 participants