Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sql.DB to Postgres and Mysql structs to allow closing in Close() #98

Conversation

Kay-Zee
Copy link
Contributor

@Kay-Zee Kay-Zee commented Sep 7, 2018

ref #97

Closes the underlying sql.DB when Close() is called for the two Drivers that uses sql.Conn

Only noticed this behaviour for Postgres and Mysql.

Let me know if you're happy with the way the two errors are handled in Close()

@coveralls
Copy link

coveralls commented Sep 7, 2018

Pull Request Test Coverage Report for Build 180

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.813%

Totals Coverage Status
Change from base Build 178: 0.0%
Covered Lines: 705
Relevant Lines: 1506

💛 - Coveralls

@dhui dhui merged commit f8c8573 into golang-migrate:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants