Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openpgp: enable signing using a subkey that does not have the primary key private material #173

Closed
wants to merge 1 commit into from

Conversation

djgilcrease
Copy link

@djgilcrease djgilcrease commented Jan 12, 2021

This addresses issue golang/go#23226 which allows users to follow the best practice of keeping their primary key offline.
https://riseup.net/en/security/message-security/openpgp/best-practices#have-a-separate-subkey-for-signing

closes: golang/go#13605
closes: golang/go#23226
closes: golang/go#9312

… key private material

This addresses issue #23226 which allows users to follow the best practice of keeping their primary key offline.
https://riseup.net/en/security/message-security/openpgp/best-practices#have-a-separate-subkey-for-signing
@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: a6479cf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/283234 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/283234.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dj Gilcrease:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/283234.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dj Gilcrease:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/283234.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dj Gilcrease:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/283234.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dj Gilcrease:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/283234.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dj Gilcrease:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/283234.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/283234 has been abandoned.

The x/crypto/openpgp package is now frozen, so it won't accept any more non-security changes. Thank you for opening a PR and sorry for the significant lag. You might want to consider submitting this change to one of the community forks of this package instead. See https://golang.org/issues/44226 for more information about this decision.

@gopherbot gopherbot closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants