-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openpgp: enable signing using a subkey that does not have the primary key private material #173
Conversation
… key private material This addresses issue #23226 which allows users to follow the best practice of keeping their primary key offline. https://riseup.net/en/security/message-security/openpgp/best-practices#have-a-separate-subkey-for-signing
This PR (HEAD: a6479cf) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/283234 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/283234. |
Message from Dj Gilcrease: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/283234. |
Message from Dj Gilcrease: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/283234. |
Message from Dj Gilcrease: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/283234. |
Message from Dj Gilcrease: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/283234. |
Message from Dj Gilcrease: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/283234. |
This PR is being closed because golang.org/cl/283234 has been abandoned. The x/crypto/openpgp package is now frozen, so it won't accept any more non-security changes. Thank you for opening a PR and sorry for the significant lag. You might want to consider submitting this change to one of the community forks of this package instead. See https://golang.org/issues/44226 for more information about this decision. |
This addresses issue golang/go#23226 which allows users to follow the best practice of keeping their primary key offline.
https://riseup.net/en/security/message-security/openpgp/best-practices#have-a-separate-subkey-for-signing
closes: golang/go#13605
closes: golang/go#23226
closes: golang/go#9312