-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh/knownhosts: fix bracket normalisation #268
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1. When using the bracketed syntax, the port is mandatory, even if it's the default one. Otherwise, OpenSSH rejects it with: "address [abcd:abcd:abcd:abcd]: missing port in address". See sshd(8): SSH_KNOWN_HOSTS FILE FORMAT. 2. Brackets are not necessary when using the default port, even for IPv6 addresses. Fixes golang/go#53463
6129f06
to
71680b0
Compare
This PR (HEAD: 71680b0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/522255. Important tips:
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/522255. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/522255. |
When using the bracketed syntax, the port is mandatory, even if
it's the default one. Otherwise, OpenSSH rejects it with:
"address [abcd:abcd:abcd:abcd]: missing port in address".
See sshd(8): SSH_KNOWN_HOSTS FILE FORMAT.
Brackets are not necessary when using the default port,
even for IPv6 addresses.
Fixes golang/go#53463