-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh: add top-level DialContext #280
base: master
Are you sure you want to change the base?
Conversation
DialContext starts a client connection to the given SSH server using the supplied Context. The supplied Context affects the dial and handshake. If it expires after the connection is opened, it has no effect on the resulting Client.
This PR (HEAD: 69b3f59) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/550096. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550096. |
Message from Randy Reddig: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550096. |
I would appreciate any movement on this PR. |
@dennypenta We use Gerrit for code review. The place to comment is https://go.dev/cl/550096. Thanks. |
Message from Jean-Yves Pellé: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/550096. |
Add a top-level convenience function DialContext, mirroring func Dial.
func DialContext(ctx context.Context, network, addr string, config
*ClientConfig) (*Client, error)
DialContext func accepts a context.Context as its first argument, which
controls the dial and handshake phases of the connection. Closing the Context
after the connection is established has no effect on the resulting Client.
Fixes golang/go#64686.