Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: add top-level DialContext #280

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Dec 17, 2023

Add a top-level convenience function DialContext, mirroring func Dial.

func DialContext(ctx context.Context, network, addr string, config
*ClientConfig) (*Client, error)

DialContext func accepts a context.Context as its first argument, which
controls the dial and handshake phases of the connection. Closing the Context
after the connection is established has no effect on the resulting Client.

Fixes golang/go#64686.

ydnar and others added 3 commits December 18, 2023 11:30
DialContext starts a client connection to the given SSH server using the supplied Context.
The supplied Context affects the dial and handshake. If it expires after the connection
is opened, it has no effect on the resulting Client.
@gopherbot
Copy link
Contributor

This PR (HEAD: 69b3f59) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/550096.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/550096.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/550096.
After addressing review feedback, remember to publish your drafts!

@dennypenta
Copy link

I would appreciate any movement on this PR.
scp client would benefit from it

@ianlancetaylor
Copy link
Contributor

@dennypenta We use Gerrit for code review. The place to comment is https://go.dev/cl/550096. Thanks.

@gopherbot
Copy link
Contributor

Message from Jean-Yves Pellé:

Patch Set 2: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/550096.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: x/crypto/ssh: add top-level DialContext func
4 participants