Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

-old flag for dep status command is not implemented. #1046

Closed
dmitshur opened this issue Aug 21, 2017 · 4 comments · Fixed by #1057
Closed

-old flag for dep status command is not implemented. #1046

dmitshur opened this issue Aug 21, 2017 · 4 comments · Fixed by #1057

Comments

@dmitshur
Copy link
Contributor

The only mentions of old value are:

fs.BoolVar(&cmd.old, "old", false, "only show out-of-date dependencies")

And:

old bool

So, dep status and dep status -old produce identical output.

Is it not implemented because this is a known TODO?

@dmitshur
Copy link
Contributor Author

When you run dep status -detailed, you at least get a helpful error message:

$ dep status -detailed
not implemented

Doing nothing for -old is misleading because it's not immediately obvious from output that even non-old entries are being shown. So a short term solution is to fail with "not implemented" error message.

@adamo57
Copy link
Contributor

adamo57 commented Aug 21, 2017

I could take this on.

@darkowlzz
Copy link
Collaborator

darkowlzz commented Aug 22, 2017

@shurcooL thanks for a push. Status is getting the next development focus. We already have PR #613 with implementation of -old and other similar flags. We are still working out the details of all the status run modes.

We can add not implemented to the unimplemented flags, if that helps for now. @adamo57 you're welcome to send a PR for that :)

@dmitshur
Copy link
Contributor Author

dmitshur commented Aug 22, 2017

I see, if it's already being worked on, that sounds good. Thanks. I'd suggest adding a Resolves #1046. sentence to that PR description to make the association.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants