Always use trailing newlines in multi line arrays

[vektah]

#1461 switched to using multi line toml arrays in the lock file, while this improved readability it also introduced some additional diff churn.

Before:

- packages = [".","a"]
+ packages = [".","a","b"]

After:

packages = [
    "."
-   "a"
+   "a",
+   "b"
]

This is bad because it increases the chance of merge conflicts in the lock and decreases readability. It was also one of the reasons toml was chosen over a more mainstream format like json.

Proposal: Always add trailing commas, just like in go. This probably requires an upstream change to the toml library.

[sdboyer]

i don't actually know if TOML allows trailing commas, but if it does, this seems like a clear win.

but yeah, it'll be a todo for our TOML lib - /cc @pelletier

[pelletier]

TOML does support trailing commas (and so does go-toml). That sounds like a small addition to the new Encoder feature :) -- Thomas Pelletier

[ctd1500]

Trailing commas are now implemented in the TOML library: pelletier/go-toml#217

[sdboyer-stripe]

sweet! thanks @ctd1500. we'll get this incorporated as soon as there's a new go-toml release 😄

[pelletier]

Released go-toml 1.2.0 https://github.com/pelletier/go-toml/releases/tag/v1.2.0 for that

[sdboyer]

thank you!