Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Output multi-element TOML arrays on newlines #1461

Merged
merged 3 commits into from
Dec 18, 2017

Conversation

sdboyer
Copy link
Member

@sdboyer sdboyer commented Dec 18, 2017

What does this do / why do we need it?

Our TOML integration currently writes out multi-element arrays on a single line. This is not great for reading, and also not great for comprehensible diffs and erroneous conflicts. Our TOML lib just updated to add support for writing each item on a newline, and this PR incorporates the new logic.

What should your reviewer look out for in this PR?

i don't think we need any more exhaustive testing on this - seems like what we have should be sufficient.

@sdboyer sdboyer added this to the v0.4.0 milestone Dec 18, 2017
Copy link
Collaborator

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🎉 This is much easier to read.

@sdboyer sdboyer merged commit 132ea90 into golang:master Dec 18, 2017
@vektah
Copy link

vektah commented Jan 28, 2018

It would be nice if we had trailing commas on the final line to reduce diff noise:

packages = [
   ".",
   "subp"
]

vs

packages = [
   ".",
   "subp",
]

Also, is there any way to add a dep version requirement to the manifest? similar to npm's engines so we can prompt other devs working with our codebases that they need to update dep?

@sdboyer
Copy link
Member Author

sdboyer commented Jan 29, 2018

@vektah new issues for each of those, please 😊

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants