This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Output multi-element TOML arrays on newlines #1461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Our TOML integration currently writes out multi-element arrays on a single line. This is not great for reading, and also not great for comprehensible diffs and erroneous conflicts. Our TOML lib just updated to add support for writing each item on a newline, and this PR incorporates the new logic.
What should your reviewer look out for in this PR?
i don't think we need any more exhaustive testing on this - seems like what we have should be sufficient.