Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Add check that hot-switching from default to alternate Source is "safe" #428

Closed
fabulous-gopher opened this issue Apr 21, 2017 · 0 comments

Comments

@fabulous-gopher
Copy link

From @sdboyer on January 15, 2017 20:0

When ProjectIdentifier.Source is empty for a given project, it's possible for a later dependency on that same project to come along and specify a ProjectIdentifier.Source, and the solver will transparently allow the switch to the alternate source location.

This is useful because it allows (one) project to specify an alternate source location - primarily, a fork - and have other dependers on that project just go along for the ride. Not having this feature would make specifying a fork of a shared dep nearly impossible; all the dependers on it would need to explicitly specify the fork. However, right now, we don't really do any checks to ensure that this hot-switching of source locations is actually safe - we just make a simple check, and off we go.

TBH, I'm not even sure what "safe" would even mean here, as the express purpose of having a fork is to use a modified version of the code, which necessarily means relying on a different version. We need better, clearer definitions.

Copied from original issue: sdboyer/gps#144

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants