This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Unify alternate source IDs in solver to avoid duplicate projects #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
force-pushed
the
source-and-disjoint
branch
from
21e8fd1
to
e7c818f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #969. This is insanely deep in the solver, so I'm not actually expecting anyone to review it.
In short, when we encountered a dependency for the second time, and the first time established an alternate
source, but the second time did not (a case we allow for now even though it's maybe kind of a bad idea - #428), we weren't keeping track of that alternate source on the new bimodal identifier that was pushed into the unselected queue.We have a new test case that now and only passes with the new change.