This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
ensure: add tests and behavior for when a dep is unused #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
suggested changes
Jan 18, 2017
|
|
||
| if !found { | ||
| fmt.Fprintf(os.Stdout, `WARNING: %s was requested but is not imported in your code. | ||
| Run again with --require to ensure it is vendored and added to the lock. |
| @@ -153,6 +157,44 @@ func (cmd *ensureCommand) Run(args []string) error { | |||
| } | |||
| } | |||
|
|
|||
| // add all the required packages to required in the manifest | |||
| for _, arg := range cmd.requires { | |||
| pc, err := getProjectConstraint(arg, sm) | |||
There was a problem hiding this comment.
because requires are pkg-level rather than project-level, i wonder if it might be better to not allow the user to specify a constraint at the same time as they specify a require (or an ignore)
There was a problem hiding this comment.
Hmmm idk because then they would have to put it twice to ensure we could just say you get the project at the constraint but you are requiring that it doesn't disappear since you aren't using it
sdboyer
approved these changes
Jan 19, 2017
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Closed
|
I'm gonna close this out, since we're moving towards a different vision of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
behaves in the following way:
part of #36