This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
ci: enforce that dep prune is run #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
force-pushed
the
require-pruning
branch
from
d9ecedd
to
808f22c
Compare
tamird
approved these changes
Sep 12, 2017
hack/validate-vendor.bash
Outdated
| mv $TMP_FILE Gopkg.lock | ||
|
|
||
| # We run ensure to and see if we have a diff afterwards | ||
| # We run ensure and prune to and see if we have a diff afterwards |
There was a problem hiding this comment.
Just remove this comment, it's not helpful
sdboyer
force-pushed
the
require-pruning
branch
from
808f22c
to
4933220
Compare
ebati
reviewed
Sep 12, 2017
hack/validate-vendor.bash
Outdated
| mv $TMP_FILE Gopkg.lock | ||
|
|
||
| # We run ensure to and see if we have a diff afterwards | ||
| # We run ensure and prune to and see if we have a diff afterwards | ||
| go build ./cmd/dep | ||
| ./dep ensure |
There was a problem hiding this comment.
Is it better to use vendor-only? Change in lock (update of the dependency) and the commit(this script run against) can be unrelated.
There was a problem hiding this comment.
derp, that was in there originally and i lost it in my fast commit amending. it's mostly better to do this, though it doesn't do 💯 of what we want.
sdboyer
force-pushed
the
require-pruning
branch
from
4933220
to
50bcf4c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
because we need to minimize our
vendorfolder size, like everyone else.What should your reviewer look out for in this PR?
dumb mistakes.
Do you need help or clarification on anything?
nope