Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

[WIP] Feature to disable file locking when DEPNOLOCK set #1206

Merged
merged 7 commits into from
Sep 29, 2017
Merged

[WIP] Feature to disable file locking when DEPNOLOCK set #1206

merged 7 commits into from
Sep 29, 2017

Commits on Sep 27, 2017

  1. Disable file locking when DEPNOLOCK set 

    * Add DisableLocking bool members to Ctx and gps.SourceManagerConfig structs.
  This effectively communicates DEPNOLOCK from the shell, to Ctx, to
  SourceManager.

  The member is named DisableLocking to make its zero-value useful.

* Add locker interface which implements TryLock(), Unlock(), and GetOwner()
  which lockfile.Lockfile alredy adheres to.  This interface replaces the new
  type for the lf member of the SourceMgr struct.

* Add a FalseLocker type which adheres to the Locker interface which does
  nothing.

* Conditionally set the lf member of SourceMgr to either an instance of
  lockfile.Lockfile or FalseLocker depending on the value of
  SourceManagerConfig.DisableLocking.

Signed-off-by: Ayan George <[email protected]>
    @ayang64
    ayang64 committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    c0a4551 View commit details
    Browse the repository at this point in the history

  2. Revert stray edit. 

    Signed-off-by: Ayan George <[email protected]>
    @ayang64
    ayang64 committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    0088119 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2017

  1. Improve comment for DisableLocking 

    Signed-off-by: Ayan George <[email protected]>
    @ayang64
    ayang64 committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    3faed10 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2017

  1. Fix comment type-os

    @ayang64
    ayang64 committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    744d239 View commit details
    Browse the repository at this point in the history

  2. Fix comment type-os 

    Signed-off-by: Ayan George <[email protected]>
    @ayang64
    ayang64 committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    0dec1c3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dep-no-lock' of github.com:ayang64/dep into dep-no-lock

    @ayang64
    ayang64 committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    f6a117f View commit details
    Browse the repository at this point in the history

  4. Fix yet more type-os. 

    Signed-off-by: Ayan George <[email protected]>
    @ayang64
    ayang64 committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    0b746f9 View commit details
    Browse the repository at this point in the history