This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
gps: source cache: memory cache optimization #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice store-and-copy and proper locking
…in order to avoid depending on len(0) vs nil distinction
sdboyer
approved these changes
Sep 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This PR optimizes
singleSourceCacheMemory.getAllVersions(), fixes a bug, and clears up an error-pronelen(0)v.s.nilslice distinction.This is the optimization that exposed the bug fixed in #1212,
and is blocked by that change (but putting it up now provides some context).Edit: Unblocked.Related to #431