This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Collect Applicable Constraints - Test Cleanup #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was fine, but this is good to have :) |
darkowlzz
reviewed
Dec 29, 2017
cmd/dep/status_test.go
Outdated
| `) | ||
| testdir := filepath.Join("src", "collect_constraints_test") | ||
| h.TempDir(testdir) | ||
| h.TempCopy(filepath.Join(testdir, "main.go"), "status/collect_constraints/main.go") |
There was a problem hiding this comment.
Maybe use filepath.Join() here for "status/collect_constraints/main.go" to be safe?
|
haha yeah, I just felt a bit weird having the code as a string there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Made a
testdatadir and test file forTestCollectConstaints.Forgot to include this in #1480
What should your reviewer look out for in this PR?
Do you need help or clarification on anything?
Which issue(s) does this PR fix?