Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

gps: source cache: enable opt-in persistent caching via DEPCACHEAGE env var #1711

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Feb 24, 2018

What does this do / why do we need it?

This PR enables opt-in persistent source caching, via the $DEPCACHEAGE environment variable. By setting a duration (e.g. 24h), source info written to cache since <duration> ago will be accepted.

Testing lock file regeneration for cockroachdb (rm Gopkg.lock; dep ensure -no-vendor) on my machine shows speedup from around 1m30s to 10s.

This feature is opt-in only for now, so an unset $DEPCACHEAGE will not use the new cache. In the future caching may be the default, and this var would be used to override (perhaps with an additional more explicit -no-cache flag to disable per invocation).

Sources are cached under the dep cache directory as bolt-v1.db. This file can be nuked if necessary, though I have had good luck thus far.

What should your reviewer look out for in this PR?

A better env var name, or better field names in the API.

Which issue(s) does this PR fix?

Nearly #431.

Copy link
Member

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's time for this one to go in.

@sdboyer sdboyer merged commit a6b1e89 into golang:master Jun 5, 2018
@jmank88 jmank88 deleted the cache branch June 5, 2018 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants