Implement missing flag for dep status #1870
Conversation
Comply with command spec by making dep status -missing list the dependencies that are missing from the lock file but are used in the project. If there are no dependencies missing it returns "No missing dependencies found." If there are errors preventing the execution of dep status, the error msg will be displayed instead.
|
Thanks for creating this PR. Looks like there is some misunderstanding in what we want from the #613 was just an experiment but #1382 is for a proper implementation of the Can you refer to Hope this helps. Feel free to ask if there's any confusion. |
Comply with command spec by making dep status -missing list the dependencies that are missing from the lock file but are used in the project. Issue golang#1382.
|
Thank you for the detailed explanation, feedback on the updated PR is appreciated. Also, since #613 is a bit older, there is now some "more advanced" stuff in runStatusAll() such as the outputter and the ability to list missing packages per project. A short clarification if the -missing flag should deliberately not adopt them to keep it simple or if they should be picked up eventually would be nice. |
There was a problem hiding this comment.
Also, since #613 is a bit older, there is now some "more advanced" stuff in runStatusAll() such as the outputter and the ability to list missing packages per project. A short clarification if the -missing flag should deliberately not adopt them to keep it simple or if they should be picked up eventually would be nice.
No, we don't need that. Missing is project specific, no need to list missing packages per project.
This looks good to me. But as in the spec doc, we need to support output formats, template (-f) and json (-json) format. Can you add those as well? If not, we can add them in a follow-up PR.
| @@ -0,0 +1,13 @@ | |||
| // Copyright 2017 The Go Authors. All rights reserved. | |||
cmd/dep/status_test.go
Outdated
| }, | ||
| wantStatus: "Missing dependencies (not present in lock):\n" + | ||
| " github.com/boltdb/bolt\n" + | ||
| " github.com/sdboyer/dep-test\n", |
There was a problem hiding this comment.
You can use back tick (`) as well if you would like to avoid appending with + and \n.
Comply with command spec by making dep status -missing list the dependencies that are missing from the lock file but are used in the project. Issue golang#1382.
tinnefeld
force-pushed
the
issue-1382-missing-flag-for-dep-status
branch
from
6ea763c
to
391e768
Compare
|
Thank you for the feedback, I incorporated it and added corresponding tests. Sorry for the delay. |
Minor code cleanup to comply with linting. Issue golang#1382.
|
@sdboyer v0.5.0 is out. Just sayin'… |
|
Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks! |
What does this do / why do we need it?
Comply with command spec by making dep status -missing
list the dependencies that are missing from the lock file
but are used in the project.
If there are no dependencies missing it returns "No missing
dependencies found." If there are errors preventing the
execution of dep status, the error msg will be displayed instead.
What should your reviewer look out for in this PR?
Obviously, this will be superseded by the new status run mode currently WIP in [1]. However, it brings compatibility with the spec [2] / gets rid of "not implemented" in the meantime.
[1] #613
[2] https://docs.google.com/document/d/1Qwa3jDKDh45t5qAGjRpeu3ZsAbkukIYDDmYJdMxH2uY/edit?usp=sharing
Which issue(s) does this PR fix?
fixes #1382