This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
dep: Allow explicitly setting the project root via an env var #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
changed the title
This is potentially useful when working on projects that aren't compiled by the standard toolchain (e.g., by Bazel), and thus don't need to live within a GOPATH. It also comports with the upcoming changes to do away with GOPATH.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This allows the user to set the project root explicitly, instead of inferring it from the current GOPATH, via the
DEPPROJECTROOTenvironment variable.This is potentially useful when working on projects that aren't compiled
by the standard toolchain (e.g., by Bazel), and thus don't need to live
within a GOPATH.
It also comports with the upcoming changes to do away with GOPATH.
/cc @jmillikin-stripe
What should your reviewer look out for in this PR?
This does still allow the root to be explicitly set when the cwd is within a GOPATH. That behavior might be a little wacky, but it doesn't seem terrible, so not worth the up-front effort to seal it off.