Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Don't exclude Godeps folder. Fixes #1822 #1921

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Don't exclude Godeps folder. Fixes #1822 #1921

merged 1 commit into from
Jul 4, 2018

Conversation

jonstacks
Copy link
Contributor

Fixes #1822. Talked with @sdboyer and I think its safe to remove this. Tested this on a project with an old Godeps folder and it solved perfectly.

@jonstacks jonstacks requested a review from sdboyer as a code owner July 4, 2018 04:21
sdboyer
sdboyer approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! It's important to exclude vendor because of its special semantics, but excluding Godeps doesn't really help anything, and it just hurts folks who are stuck with older versions of dependencies because (reasons)

@sdboyer sdboyer merged commit 1208520 into golang:master Jul 4, 2018
@jonstacks jonstacks deleted the godeps branch July 5, 2018 01:40
@sdboyer sdboyer mentioned this pull request Jul 13, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdboyer sdboyer sdboyer approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonstacks @sdboyer @googlebot