This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
dep: Introduce noverify field to Gopkg.toml #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field allows bypassing of vendor verification on a project-by-project basis. When set, `dep check` will ignore any hash verification problems with the directory, and `dep ensure` will not rewrite the dependency unless it is absent from vendor entirely, pruning rules change, or solving changes one of the other, higher-order properties.
This also updates the harness test system to be able to sniff for non-zero exit cases. Doing so is important for dep check, as it is specifically designed for automated use based on exit status.
Without this, there's really no easy way to see what things marked noverify are actually in a divergent state, and that information is crucial. If the user doesn't care, or specifically wants to suppress it, -q is always an option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This introduces a
noverifyfield inGopkg.tomlthat will allow bypassing of vendor verification (#1912) on a per-project basis. When set,dep checkwill ignore any hash verification problems with the directory, anddep ensurewill not rewrite the dependency unless it is absent from vendor entirely, pruning rules change, or solving changes one of the other, higher-order properties.We may want to switch to the safer behavior, in which we always rewrite
vendorfor non-verified projects, rather than only rewriting it if a higher-order change occurs. We'll have to see how it pans out. If we want to make the change, though, it's as simple as commenting one line and uncommenting another.TODO
What should your reviewer look out for in this PR?
Weird combinations that i've missed?
Do you need help or clarification on anything?
Right now,
dep checkprints nothing for noverify projects on 1) empty hash 2) hash mismatch 3) hash version mismatch; would it be preferable to print the normal message + a suffix that says it's noverify, then still exit 0 instead of just silently exiting 0?Which issue(s) does this PR fix?
fixes #1933