This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
pkgtree: fix handling of cyclic import graphs #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determining reachability in the face of cyclic imports requires "merging" the reachsets of the packages in the cycle. Previously, dep could nondeterministically lose dependencies in cyclic graphs depending on the order in which it traversed the graph. Fix golang#2001.
In wmToReach, self-imports are now handled properly by the general cycle-handling code (i.e., when a package is colored grey). There is no longer any need to special case self-imports, which are just zero-length cycles.
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determining reachability in the face of cyclic imports requires
"merging" the reachsets of the packages in the cycle. Previously, dep
could nondeterministically lose dependencies in cyclic graphs depending
on the order in which it traversed the graph.
Fix #2001.