This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Fix ARM (v6/7) CI release to Github and resulting install script erroring out on 404 #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey get uploaded to Github
|
@kevinburke Can this fairly trivial change be merged to fix issues for users with for example a Raspberry Pi? A |
|
On it! I think I need to submit again to get the tests passing |
kevinburke
added a commit
that referenced
this pull request
Apr 10, 2019
In January, #2102 was closed with 5ae9d8b to build ARMv6/7 binaries. This seems to be working, but there are no release files uploaded to Github for this architecture, because the wrong filenames are used in .travis-ci. This PR fixes that. It must be noted that the dep install script is already modified to expect a ARMv6/7 binary in the Github releases, so it errors out on 404 instead of emitting a clear error message which it did before: ``` Fetching https://github.com/golang/dep/releases/download/v0.5.1/dep-linux-arm Request failed with code 404 ``` Originally submitted by Github user confiks as #2135.
|
Merged as 1c9da2d. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In January, PR #2102 was closed with 5ae9d8b to build ARMv6/7 binaries. This seems to be working, but there are no release files uploaded to Github for this architecture, because the wrong filenames are used in
.travis-ci. This PR fixes that.It must be noted that the
depinstall script is already modified to expect a ARMv6/7 binary in the Github releases, so it errors out on 404 instead of emitting a clear error message which it did before:To fix this, perhaps the binary can be manually added to the v0.5.1 release, or the Travis CI job be rerun as v0.5.2.