Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Fixed validate-vendor.bash to work with current dep implementation. #648

Merged
merged 2 commits into from
May 25, 2017
Merged

Fixed validate-vendor.bash to work with current dep implementation. #648

merged 2 commits into from
May 25, 2017

Conversation

gregory-m
Copy link
Contributor

@gregory-m gregory-m commented May 25, 2017

Fixes #645

I added sed command to validate-vendor.bash to strip memo from Gopkg.lock
It works for both GNU sed (Linux) and BSD sed (MacOS).

Here failed test build before running dep ensure: https://travis-ci.org/golang/dep/builds/235966915
And success build after running dep ensure: https://travis-ci.org/golang/dep/builds/235984505

This should be reverted after -vendor-only flag will be implemented.
See #645 for more details.

Fixes #645
After we have working validate-vendor.bash we need ensure dependencies
to make it happy
@gregory-m gregory-m changed the title [WIP] Fixed validate-vendor.bash to work with current dep implementation. Fixed validate-vendor.bash to work with current dep implementation. May 25, 2017
@sdboyer
Copy link
Member

sdboyer commented May 25, 2017

oh awesome, thank you!

@sdboyer sdboyer merged commit 83e2b6f into golang:master May 25, 2017
@gregory-m
Copy link
Contributor Author

Thanks for review.
Just one not connected question.

Did reviewers receive notification about new changes after they requested change?
Or I need to manually add comment and ask for next review round?

For example, have you received notification after I pushed new changes to #635 ?
(I'am not pushing you to review just want to learn about workflow)

Thanks.

@sdboyer
Copy link
Member

sdboyer commented May 25, 2017

no worries - yep, i'm notified when you push changes or comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants