This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Apply common validations to all import conversion unit tests #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
remove-matchpairedrevision
branch
from
c123f59
to
996a18f
Compare
|
@sebdah let me know if I have borked up your table tests. Hoping this will be helpful as we add more! |
|
@carolynvs This is a change for the better! Especially if we introduce more importers. Good job 🚀 |
* Remove matchVersionPair flag and validate the cast anytime a * wantRevision was specified. * Always validate lock properties when a lock is generated.
carolynvs
force-pushed
the
remove-matchpairedrevision
branch
from
8d34136
to
a711f16
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
#897 took the first steps to standardize what all the importers test. This takes it a bit further so that each importer isn't re-implementing the validations. I also noticed a few properties weren't being validated consistently:
matchVersionPairflag and validate the cast anytime awantRevisionwas specified.Heads up: This will impact #978.