Update CI and add version command #996
Conversation
| ```sh | ||
| $ go get -u github.com/golang/dep/cmd/dep | ||
| ``` | ||
| Grab the latest binary from the [releases](https://github.com/golang/dep/releases) page. |
There was a problem hiding this comment.
I'm not sure we want to remove the traditional way of getting Go tools from the README. 🤔
There was a problem hiding this comment.
Will go get be the normal users installation method or it will be there as a note developers. If it is for normal use, I dont think it is a good idea to use tool from the tip of the master.
There was a problem hiding this comment.
i don't think we can remove it, but we should de-emphasize it - put it after other recommended methods.
i'd prefer to have a bash script, so that we can easily run it from elsewhere if needed. can put it under here's a block of YAML i generated for deploy:
provider: releases
api_key:
secure: fL9GX11J3JLizEBTPZHN32wuAT91eAJsGl0kjlAdIc6Lb/9UCe1XZGgFnpQFN4qo/S+omhHBDbM6Ty1xhNy7xmjDecpQGDU8Rmap9Oll0TuxqMigG+njOuPp5VUYPofPP0PGKdxAcYg+KaFM7x0o2rK+qA046NHwo2gH1BbE+bn55TZglEajEfc8j9iX4jt96KC7zlu+WiKArLmfUtlrI8m8ZYgbYcvFmlYjeCiEqlNhvNL59ejug9Rl0PLtPbamqVXkGLafYtekgPCb4WSxBiCt8pq5Rb5svk9YcdXpiaWQhZjMPAuKN6BrmN2lw1PiXzADUG5fjvNc8eo2HY70GD2utU9cAsY8VIafhoH5n6uM1WI8MHwDfd7P1PiQA3ZGQ8CPwk4q/8HSfQU9ap7vZgSF63pTIbtlviyIG67orOJE9PWWncl9olYM946UylZu6m3hWI/rmJxOeJ1UJjym/3GNPMRfKubaGhV/TyRdM0bKX4M0cXHU6k/ESVFupGXdKRt4RpvkD4/1Km6b2OShW6PNI+ifFspnJr7obkI7dm7ubySdnNz4lMv9WWymxRpMVc8hUAhuoDvXeZJq7pSnkjBEWDxIRoTkA93CU3/Rf7MFYCJMnGSqjcxWUpIfCAk2/r4BqL9NQnqBvvVt+MYi64QaD5n7ZF3dVbr6HZ2zjSU=
file: ''
on:
repo: golang/dep
i don't think so. we're not going to tag a release on a commit without it having passed all of CI anyway, so by the time the actual tag push happens, we'll already be sure that windows is 👍 . |
ebati
force-pushed
the
ci-make-version
branch
2 times, most recently
from
3d01a10
to
d764c12
Compare
ebati
changed the title
.github/ISSUE_TEMPLATE.md
Outdated
| ### What version of dep are you using (`dep version`)? | ||
| <!-- | ||
| If not using release version what version of Go (`go version`) | ||
| and `dep` (`git describe --tags`) are you using? |
There was a problem hiding this comment.
let's replace with "If you installed dep via go get, report the version instead with cd $GOPATH/src/github.com/golang/dep && git describe --tags
README.md
Outdated
| @@ -50,6 +46,12 @@ $ brew install dep | |||
| $ brew upgrade dep | |||
| ``` | |||
|
|
|||
| You can also install dep via | |||
There was a problem hiding this comment.
let's further advise against this by making the sentence read:
"If you're interested in hacking on dep, you can install via go get:"
|
weee! |
|
608446434 |
|
department |
|
dep |
What does this do / why do we need it?
What should your reviewer look out for in this PR?
Do you need help or clarification on anything?
Which issue(s) does this PR fix?