-
Notifications
You must be signed in to change notification settings - Fork 17.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmd/cgo: add hooks for thread sanitizer
When Go code is used with C code compiled with -fsanitize=thread, adds thread sanitizer calls so that correctly synchronized Go code does not cause spurious failure reports from the thread sanitizer. This may cause some false negatives, but for the thread sanitizer what is most important is avoiding false positives. Change-Id: If670e4a6f2874c7a2be2ff7db8728c6036340a52 Reviewed-on: https://go-review.googlesource.com/17421 Reviewed-by: Dmitry Vyukov <[email protected]>
- Loading branch information
1 parent
c86dbbe
commit c8ef0df
Showing
4 changed files
with
228 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // Copyright 2015 The Go Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| package main | ||
|
|
||
| // This program produced false race reports when run under the C/C++ | ||
| // ThreadSanitizer, as it did not understand the synchronization in | ||
| // the Go code. | ||
|
|
||
| /* | ||
| #cgo CFLAGS: -fsanitize=thread | ||
| #cgo LDFLAGS: -fsanitize=thread | ||
| int val; | ||
| int getVal() { | ||
| return val; | ||
| } | ||
| void setVal(int i) { | ||
| val = i; | ||
| } | ||
| */ | ||
| import "C" | ||
|
|
||
| import ( | ||
| "runtime" | ||
| ) | ||
|
|
||
| func main() { | ||
| runtime.LockOSThread() | ||
| C.setVal(1) | ||
| c := make(chan bool) | ||
| go func() { | ||
| runtime.LockOSThread() | ||
| C.setVal(2) | ||
| c <- true | ||
| }() | ||
| <-c | ||
| if v := C.getVal(); v != 2 { | ||
| panic(v) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // Copyright 2015 The Go Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| package main | ||
|
|
||
| // This program produced false race reports when run under the C/C++ | ||
| // ThreadSanitizer, as it did not understand the synchronization in | ||
| // the Go code. | ||
|
|
||
| /* | ||
| #cgo CFLAGS: -fsanitize=thread | ||
| #cgo LDFLAGS: -fsanitize=thread | ||
| extern void GoRun(void); | ||
| // Yes, you can have definitions if you use //export, as long as they are weak. | ||
| int val __attribute__ ((weak)); | ||
| int run(void) __attribute__ ((weak)); | ||
| int run() { | ||
| val = 1; | ||
| GoRun(); | ||
| return val; | ||
| } | ||
| void setVal(int) __attribute__ ((weak)); | ||
| void setVal(int i) { | ||
| val = i; | ||
| } | ||
| */ | ||
| import "C" | ||
|
|
||
| import "runtime" | ||
|
|
||
| //export GoRun | ||
| func GoRun() { | ||
| runtime.LockOSThread() | ||
| c := make(chan bool) | ||
| go func() { | ||
| runtime.LockOSThread() | ||
| C.setVal(2) | ||
| c <- true | ||
| }() | ||
| <-c | ||
| } | ||
|
|
||
| func main() { | ||
| if v := C.run(); v != 2 { | ||
| panic(v) | ||
| } | ||
| } |
Oops, something went wrong.