cmd/asm: hang #11764
Labels
Milestone
Comments
|
CL https://golang.org/cl/13920 mentions this issue. |
|
CL https://golang.org/cl/14225 mentions this issue. |
adg
pushed a commit
that referenced
this issue
Sep 8, 2015
For ARM machines, the assembler supports list of registers operands such as [R1,R2]. A list missing a ']' results in the parser issuing many errors and consuming all the tokens. At EOF (i.e. end of the line), it still loops. Normally, a counter is maintained to make sure the parser stops after 10 errors. However, multiple errors occuring on the same line are simply ignored. Only the first one is reported. At most one error per line is accounted. Missing ']' in a register list therefore results in an infinite loop. Fixed the parser by explicitly checking for ']' to interrupt this loops In the operand tests, also fixed a wrong entry which I think was not set on purpose (but still led to a successful result). Fixes #11764 Change-Id: Ie87773388ee0d21b3a2a4cb941d4d911d0230ba4 Reviewed-on: https://go-review.googlesource.com/13920 Reviewed-by: Rob Pike <[email protected]> Reviewed-on: https://go-review.googlesource.com/14225
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
cmd/asm hangs on the following program:
go version devel +9b04852 Sat Jul 11 00:08:50 2015 +0000 linux/amd64
The text was updated successfully, but these errors were encountered: