x/tools/cmd/getgo: installer does not work on alpine using sh

[SamWhited]

What version of Go are you using (go version)?

None yet, trying to install it!

What operating system and processor architecture are you using (go env)?

Linux amd64

What did you do?

$ docker pull alpine:latest
$ docker run -i -t alpine:latest /bin/sh
# apk update && apk add curl
# curl -LO https://get.golang.org/$(uname)/go_installer && chmod +x go_installer && ./go_installer && rm go_installer
Welcome to the Go installer!
Downloading Go version go1.8.3 to /root/.go
This may take a bit of time...
"" is not a supported shell

What did you expect to see?

Go installed (or at least "sh" is not a supported shell if bourne shells are required or something similar)

What did you see instead?

"" is not a supported shell

[jessfraz]

set -e SHELL=sh on the container

[SamWhited]

Thanks! I didn't realize it was getting the name from $SHELL. Either way, sh does not appear to be supported sadly:

"/bin/sh" is not a supported shell

[jessfraz]

so the point of the installer is to mod the rc file for the shell so we should probably add sh but also this is mainly geared towards people setting up their dev env and i dont know how common sh will be

…

On Wed, Aug 23, 2017 at 3:03 PM, Sam Whited ***@***.***> wrote: Thanks! I didn't realize it was getting the name from $SHELL. Either way, sh does not appear to be supported sadly: "/bin/sh" is not a supported shell — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#21264 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYNbGg4VWdtqinvf86MgVisafDo-o9zks5sbHeUgaJpZM4OqT7s> .

-- Jessie Frazelle 4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3 pgp.mit.edu <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>

[cuonglm]

so the point of the installer is to mod the rc file for the shell so we
should probably add sh but also this is mainly geared towards people
setting up their dev env and i dont know how common sh will be

The fact is that sh must be present in any POSIX compliant systems, but its path isn't standard, can be /bin/sh or /usr/xpg4/bin/sh ...

Also rc file isn't mandatory by POSIX spec, so I see the installer only support bash and zsh for now.

I think a more friendly approach is printing all the export lines, and convince the user to export them when start the shell (when the shell is not bash, zsh or other shells which don't have rc file).

[AlexisWilke]

I ran in that problem while creating a Docker with the latest version of Go.

Somehow, the SHELL variable was defined but the go_installer was not able to find it until I did:

export SHELL=/bin/bash

Then it worked as expected.

[hyangah]

Closing - getgo is deprecated. #60951