-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: freebsd-amd64 sendfile implementation is broken. #25809
Comments
Change https://golang.org/cl/117775 mentions this issue: |
/cc @ianlancetaylor |
Add test for freebsd issue #25809. This test also fails on my Windows 10 Version 1803. My hope is that adding new test will break one of our builders. Updates #25722 Updates #25809 Change-Id: Ia103bc708b8fa3b9af57613acc44893f90b3fa18 Reviewed-on: https://go-review.googlesource.com/117775 Run-TryBot: Alex Brainman <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
It also seems to be broken (probably in the same way) on dragonfly/amd64: https://build.golang.org/log/ee2bc4ad04e72093b84fbf7f2397f13b4d98e5ed |
Change https://golang.org/cl/117698 mentions this issue: |
And solaris builder is broken too https://build.golang.org/log/170fc01900ba1c5c58d0a1caa8d1b3b0c708518f Alex |
Skip it like on freebsd until there is proper a fix for #25809 Updates #25809 Change-Id: Id53c433aee75f2a992ab6a8d58d98fd1f8a6c1c6 Reviewed-on: https://go-review.googlesource.com/117698 Run-TryBot: Tobias Klauser <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Alex Brainman <[email protected]>
Change https://golang.org/cl/117895 mentions this issue: |
On dragonfly, freebsd and solaris the sendfile syscall does not update the read position of the source fd. Update it after sendfile so successive calls start at the correct position. Fixes golang#25809 Change-Id: Iaac79f89704b75b8038d4bb60eaf793a262cdd8f Reviewed-on: https://go-review.googlesource.com/117895 Run-TryBot: Tobias Klauser <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
Add test for freebsd issue golang#25809. This test also fails on my Windows 10 Version 1803. My hope is that adding new test will break one of our builders. Updates golang#25722 Updates golang#25809 Change-Id: Ia103bc708b8fa3b9af57613acc44893f90b3fa18 Reviewed-on: https://go-review.googlesource.com/117775 Run-TryBot: Alex Brainman <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
Skip it like on freebsd until there is proper a fix for golang#25809 Updates golang#25809 Change-Id: Id53c433aee75f2a992ab6a8d58d98fd1f8a6c1c6 Reviewed-on: https://go-review.googlesource.com/117698 Run-TryBot: Tobias Klauser <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Alex Brainman <[email protected]>
On dragonfly, freebsd and solaris the sendfile syscall does not update the read position of the source fd. Update it after sendfile so successive calls start at the correct position. Fixes golang#25809 Change-Id: Iaac79f89704b75b8038d4bb60eaf793a262cdd8f Reviewed-on: https://go-review.googlesource.com/117895 Run-TryBot: Tobias Klauser <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
I was trying to come up with a variation of TestSendfile to reproduce issue #25722 on our builder, and I end-up with
https://go-review.googlesource.com/c/go/+/117655/2
that fails on freebsd-amd64-11_1 builder with
--- FAIL: TestSendfile (0.00s)
sendfile_test.go:74: have="ProProPro", but want="Produced "
FAIL
I could be wrong about that test, but all other builders are OK with it. So I suspect that freebsd-amd64 sendfile implementation is broken.
Leaving for others to decide.
Alex
The text was updated successfully, but these errors were encountered: