Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/godoc: versions info is not displayed on packages with digits in the name #26514

Closed
zegl opened this issue Jul 20, 2018 · 1 comment
Closed

x/tools/godoc: versions info is not displayed on packages with digits in the name #26514

zegl opened this issue Jul 20, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11

Comments

@zegl
Copy link
Contributor

zegl commented Jul 20, 2018 •
edited
Loading

What version of Go are you using (go version)?

2018/07/20 23:34:06 Go Documentation Server
2018/07/20 23:34:06 version = devel +59699aa166 Fri Jul 20 19:04:25 2018 +0000

Does this issue reproduce with the latest release?

Yes

What did you expect to see?

Version info about when functions and methods was added to the Go standard library should be visible on encoding/base32. Example: WithPadding was added in 1.9.

What did you see instead?

No version info.

I've debugged this and no version info is available on any package with digits in the package name. I'll submit a PR with a fix soon.
@gopherbot gopherbot added this to the Unreleased milestone Jul 20, 2018
zegl added a commit to zegl/tools that referenced this issue Jul 20, 2018
@zegl
godoc/versions: correctly parse packages with digits in the package name
b07c786 
Fixes golang/go#26514
@zegl zegl mentioned this issue Jul 20, 2018
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/125335 mentions this issue: godoc/versions: correctly parse packages with digits in the package name

@agnivade agnivade added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 21, 2018
@ysmolski ysmolski modified the milestones: Unreleased, Go1.11 Jul 21, 2018
zegl added a commit to zegl/tools that referenced this issue Jul 22, 2018
@zegl
godoc: correctly parse packages with digits in the package name
9d5fefb 
Fixes golang/go#26514
@golang golang locked and limited conversation to collaborators Jul 22, 2019
henderjon pushed a commit to oggodoc/godoc that referenced this issue Jun 13, 2024
@zegl @bradfitz
godoc: correctly parse packages with digits in the package name
54dde6c 
Fixes golang/go#26514

Change-Id: I4540737425c225c0f0c6104b5b3524621d2b0c6f
GitHub-Last-Rev: 9d5fefb6ed31579b723293c7f43fcf677ac4cddb
GitHub-Pull-Request: golang/tools#41
Reviewed-on: https://go-review.googlesource.com/125335
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
4 participants
@zegl @ysmolski @agnivade @gopherbot