Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go build 1.11 tries to rebuild shipped vendorized dependencies [1.11 backport] #27389

Closed
gopherbot opened this issue Aug 30, 2018 · 4 comments
Closed

cmd/go: go build 1.11 tries to rebuild shipped vendorized dependencies [1.11 backport] #27389

gopherbot opened this issue Aug 30, 2018 · 4 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.11.4

Comments

@gopherbot
Copy link
Contributor

@FiloSottile requested issue #27285 to be considered for backport to the next 1.11 minor release.

@gopherbot please file this for backport against 1.11. This is a regression.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 30, 2018
@gopherbot gopherbot mentioned this issue Aug 30, 2018
Closed
@gopherbot gopherbot added this to the Go1.11.1 milestone Aug 30, 2018
@katiehockman katiehockman modified the milestones: Go1.11.1, Go1.11.2 Oct 1, 2018
@bradfitz bradfitz modified the milestones: Go1.11.2, Go1.11.3 Nov 1, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Nov 1, 2018

No master fix yet, so bumped.

@bcmills
Copy link
Contributor

bcmills commented Nov 19, 2018

This has a simple workaround (stop using -i) and the fix is invasive (renaming src/vendor), so probably not worth backporting.

@bcmills bcmills closed this as completed Nov 19, 2018
@mvdan
Copy link
Member

mvdan commented Nov 21, 2018

@bcmills I think we should remove "wontfix" issues from bugfix releases. The releases page will link to this milestone for the details of what was backported, and this issue had no backport.

@FiloSottile
Copy link
Contributor

We should probably just change the release notes link to filter for CherryPickApproved.

@dmitshur dmitshur modified the milestones: Go1.11.3, Go1.11.4 Dec 13, 2018
pdecat added a commit to pdecat/terraform-provider-helm that referenced this issue Feb 5, 2019
@pdecat
Remove -i from 'go test' to allow running unit tests locally with go …
eac2ab1 
…1.11.5 (cf. golang/go#27389)
@pdecat pdecat mentioned this issue Feb 5, 2019
Merged
alexsomesan pushed a commit to hashicorp/terraform-provider-helm that referenced this issue Feb 5, 2019
@pdecat @alexsomesan
Remove -i from 'go test' to allow running unit tests locally with go …
726aa56 
…1.11.5 (cf. golang/go#27389) (#202)
@golang golang locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.11.4
Development

No branches or pull requests
7 participants
@bradfitz @FiloSottile @dmitshur @mvdan @bcmills @gopherbot @katiehockman