cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes #28856

ALTree · 2018-11-18T16:59:43Z

$ gotip version
go version devel +fe562cebf1 Sun Nov 18 16:13:13 2018 +0000 linux/amd64

To reproduce:

$ cd src/cmd/go/internal/modfetch

$ gotip test -run=TestCodeRepo
--- FAIL: TestCodeRepo (58.16s)
    --- FAIL: TestCodeRepo/gopkg.in_yaml.v2/v2 (3.32s)
        coderepo_test.go:368: info.Version = "v2.2.2-0.20181115110504-51d6538a90f8", want "v2.2.1"
        coderepo_test.go:371: info.Name = "51d6538a90f86fe93ac480b35f37b2be17fef232", want "5420a8b6744d3b0345ab293f6fcba19c978f1183"
        coderepo_test.go:374: info.Short = "51d6538a90f8", want "5420a8b6744d"
        coderepo_test.go:377: info.Time = 2018-11-15 11:05:04 +0000 UTC, want 2018-03-28 19:50:20 +0000 UTC
FAIL
exit status 1
FAIL	cmd/go/internal/modfetch	60.812s

Spotted on the longtest builder.

The text was updated successfully, but these errors were encountered:

josharian · 2018-11-18T23:27:38Z

Looks like what happened is that github.com/go-yaml/yaml added a new comment to the v2 branch: https://github.com/go-yaml/yaml/commits/v2. (Observe that previous tip was
go-yaml/yaml@5420a8b, and that new tip is
go-yaml/yaml@51d6538, which correspond to the want/have commits in the test failure.)

cc @bcmills

andybons · 2018-11-26T21:42:37Z

Why are we running tests against repos that are active and not controlled by us? Seems that we should be hitting repos that we control and are pre-baked.

@bradfitz

andybons · 2018-11-26T21:50:09Z

Adding @rsc since he wrote the original code.

dmitshur · 2018-11-26T21:56:09Z

Related issue #27692. It's another instance of the cmd/go tests relying on an external live repository.

gopherbot · 2018-12-10T22:10:36Z

Change https://golang.org/cl/153460 mentions this issue: cmd/go/internal/modfetch: update TestCodeRepo for gopkg.in/yaml.v2 v2.2.2

….2.2 I think we ought to make these tests hermetic, but in the meantime we should at least make them pass. Fixes #27692 Updates #28856 Change-Id: Ia78fa60e998dea3c871f640ffa2ece67b054f866 Reviewed-on: https://go-review.googlesource.com/c/153460 Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>

dmitshur · 2019-03-06T00:35:06Z

@bcmills I think CL 153460 has resolved this issue fully, has it not? If not, what's left here?

bcmills · 2019-03-07T22:48:44Z

@dmitshur, ideally we should make the tests hermetic (for example, by running or emulating a local Git server and substituting paths to point to it).

gopherbot · 2019-03-21T17:25:21Z

Change https://golang.org/cl/168561 mentions this issue: cmd/go/internal/modfetch: update TestCodeRepo for gopkg.in/yaml.v2

ALTree · 2019-03-21T17:27:05Z

Happened again, I sent the patch above to align the expected data for now, waiting for the test to become independent from external repositories.

New release, it broke again the longtest builder. Align the expected data with the current release. Making these tests independent of external repositories is #28856. This fixes the longtest builder. Updates #28856 Change-Id: I32d2f3325af828d26ab417a5e986e3aeefa1a897 Reviewed-on: https://go-review.googlesource.com/c/go/+/168561 Run-TryBot: Alberto Donizetti <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>

gopherbot · 2019-10-01T01:42:36Z

Change https://golang.org/cl/198117 mentions this issue: cmd/go/internal/modfetch: update TestCodeRepo for gopkg.in/yaml.v2

andybons · 2019-10-01T01:43:02Z

Happened again.

--- FAIL: TestCodeRepo (9.55s)
    --- FAIL: TestCodeRepo/parallel (0.00s)
        --- FAIL: TestCodeRepo/parallel/gopkg.in_yaml.v2/v2 (3.62s)
            coderepo_test.go:443: info.Version = "v2.2.3", want "v2.2.3-0.20190319135612-7b8349ac747c"
            coderepo_test.go:446: info.Name = "bb4e33bf68bf89cad44d386192cbed201f35b241", want "7b8349ac747c6a24702b762d2c4fd9266cf4f1d6"
            coderepo_test.go:449: info.Short = "bb4e33bf68bf", want "7b8349ac747c"
            coderepo_test.go:452: info.Time = 2019-09-30 19:09:21 +0000 UTC, want 2019-03-19 13:56:12 +0000 UTC

From https://build.golang.org/log/b73d1e539a95bac69fec321f90c305f4b69944fe

ALTree · 2019-11-05T07:52:39Z

Happened again:

386 longtest: https://build.golang.org/log/e58d459c988d41a0fbe270999a06b1a37ab82b35
amd64 longtest: https://build.golang.org/log/282e2d0bd0da52de4ceb6776fad8f1c52eae2b98

gopherbot · 2019-11-05T16:15:07Z

Change https://golang.org/cl/205437 mentions this issue: cmd/go/internal/modfetch: remove non-hermetic test

The test for gopkg.in/yaml.v2@v2 assumes that there are no future upstream releases. That assumption empirically does not hold. Backporting fixes to this test is annoying, and other gopkg.in cases are already reasonably covered, so remove the problematic test. Updates #28856 Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17 Reviewed-on: https://go-review.googlesource.com/c/go/+/205437 Run-TryBot: Bryan C. Mills <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>

gopherbot · 2019-11-05T17:06:28Z

Change https://golang.org/cl/205439 mentions this issue: [release-branch.go1.12] cmd/go/internal/modfetch: remove non-hermetic test

gopherbot · 2019-11-05T17:06:29Z

Change https://golang.org/cl/205438 mentions this issue: [release-branch.go1.13] cmd/go/internal/modfetch: remove non-hermetic test

… test The test for gopkg.in/yaml.v2@v2 assumes that there are no future upstream releases. That assumption empirically does not hold. Backporting fixes to this test is annoying, and other gopkg.in cases are already reasonably covered, so remove the problematic test. Updates #28856 Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17 Reviewed-on: https://go-review.googlesource.com/c/go/+/205437 Run-TryBot: Bryan C. Mills <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]> (cherry picked from commit f0390ff) Reviewed-on: https://go-review.googlesource.com/c/go/+/205438 Reviewed-by: Alexander Rakoczy <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

… test The test for gopkg.in/yaml.v2@v2 assumes that there are no future upstream releases. That assumption empirically does not hold. Backporting fixes to this test is annoying, and other gopkg.in cases are already reasonably covered, so remove the problematic test. Updates #28856 Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17 Reviewed-on: https://go-review.googlesource.com/c/go/+/205437 Run-TryBot: Bryan C. Mills <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]> (cherry picked from commit f0390ff) Reviewed-on: https://go-review.googlesource.com/c/go/+/205439 Reviewed-by: Alexander Rakoczy <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

dmitshur · 2020-02-25T19:51:35Z

This is neither a regression, serious bug, nor an outage, so removing Soon. It should be fixed, but that label is meant for things that are done in the order of days.

dmitshur · 2020-07-28T20:06:59Z

There were some additional cmd/go tests failing on the longtest builder because rsc.io, swtch.com, and insecure.go-get-issue-15410.appspot.com domains were not serving Go packages (see #40452).

Specifically (from https://storage.googleapis.com/go-build-log/3c347861/linux-amd64-longtest_bb29e807.log, https://storage.googleapis.com/go-build-log/2229151e/linux-386-longtest_dca9ed82.log, and https://storage.googleapis.com/go-build-log/0fcc0a58/linux-amd64-longtest_642c58db.log):

--- FAIL: TestGoGetCustomDomainWildcard (0.24s)
    go_test.go:2628: running testgo [get -u rsc.io/pdf/...]
    go_test.go:2628: standard error:
    go_test.go:2628: package rsc.io/pdf/...: unrecognized import path "rsc.io/pdf": reading https://rsc.io/pdf?go-get=1: 503 Service Unavailable
        
    go_test.go:2628: go [get -u rsc.io/pdf/...] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1
--- FAIL: TestGoGetDotSlashDownload (0.22s)
    go_test.go:2714: running testgo [get ./pprof_mac_fix]
    go_test.go:2714: standard error:
    go_test.go:2714: unrecognized import path "rsc.io/pprof_mac_fix": reading https://rsc.io/pprof_mac_fix?go-get=1: 503 Service Unavailable
        
    go_test.go:2714: go [get ./pprof_mac_fix] failed unexpectedly in /workdir/tmp/cmd-go-test-062451185/gotest700832841/src/rsc.io: exit status 1
    panic.go:617: ended in /workdir/tmp/cmd-go-test-062451185/gotest700832841/src/rsc.io
--- FAIL: TestGoGetInsecure (1.38s)
    --- FAIL: TestGoGetInsecure/gopath (0.11s)
        go_test.go:2895: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2895: standard error:
        go_test.go:2895: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
            
        go_test.go:2895: testgo failed as expected: exit status 1
        go_test.go:2898: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2898: standard error:
        go_test.go:2898: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
            
        go_test.go:2898: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1
    --- FAIL: TestGoGetInsecure/modules (1.26s)
        go_test.go:2895: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2895: standard error:
        go_test.go:2895: go get insecure.go-get-issue-15410.appspot.com/pkg/p: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
            
        go_test.go:2895: testgo failed as expected: exit status 1
        go_test.go:2898: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2898: standard error:
        go_test.go:2898: go get insecure.go-get-issue-15410.appspot.com/pkg/p: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
            
        go_test.go:2898: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/tmp/cmd-go-test-062451185/gotest738708835: exit status 1
        panic.go:617: ended in /workdir/tmp/cmd-go-test-062451185/gotest738708835
--- FAIL: TestGoGetInsecureCustomDomain (0.09s)
    go_test.go:2983: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
    go_test.go:2983: standard error:
    go_test.go:2983: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
        
    go_test.go:2983: testgo failed as expected: exit status 1
    go_test.go:2984: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
    go_test.go:2984: standard error:
    go_test.go:2984: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
        
    go_test.go:2984: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1
go test proxy running at GOPROXY=http://127.0.0.1:45253/mod
go proxy: no archive rsc.io v1.5.1: file does not exist
go proxy: no archive example.com/newcycle v1.0.0: file does not exist
go proxy: no archive rsc.io v1.0.0: file does not exist
go proxy: no archive rsc.io v1.4.0: file does not exist
go proxy: no archive rsc.io v1.5.2: file does not exist
go proxy: no archive rsc.io v1.1.0: file does not exist
go proxy: no archive rsc.io v1.0.0: file does not exist
go proxy: no archive rsc.io v1.0.0: file does not exist
go proxy: no archive rsc.io v1.0.0: file does not exist
go proxy: no archive rsc.io v1.0.0: file does not exist
go proxy: no archive golang.org v0.1.0: file does not exist
go proxy: no archive golang.org v0.3.0: file does not exist
go proxy: no archive golang.org/x v0.1.0: file does not exist
go proxy: no archive golang.org/x v0.3.0: file does not exist
go proxy: no archive example.com v0.1.0: file does not exist
go proxy: no archive rsc.io v1.5.2: file does not exist
--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_init_dep (0.24s)
        script_test.go:193: 
            # modconv uses git directly to examine what old 'go get' would (0.001s)
            # go build should populate go.mod from Gopkg.lock (0.229s)
            > cp go.mod1 go.mod
            > go build
            [stderr]
            go: copying requirements from Gopkg.lock
            go: converting Gopkg.lock: stat rsc.io/[email protected]: unrecognized import path "rsc.io/sampler": reading https://rsc.io/sampler?go-get=1: 503 Service Unavailable
            > stderr 'copying requirements from Gopkg.lock'
            > go list -m all
            [stdout]
            x
            > ! stderr 'copying requirements from Gopkg.lock'
            > stdout 'rsc.io/sampler v1.0.0'
            FAIL: testdata/script/mod_init_dep.txt:13: no match for `(?m)rsc.io/sampler v1.0.0` found in stdout
            
    --- FAIL: TestScript/mod_gonoproxy (0.78s)
        script_test.go:193: 
            # disagree with sumdb fails (0.028s)
            # but GONOSUMDB bypasses sumdb, for rsc.io/quote, rsc.io/sampler, golang.org/x/text (0.560s)
            # and GONOPROXY bypasses proxy (0.169s)
            > [!net] skip
            > [!exec:git] skip
            > env GOPRIVATE=none
            > env GONOPROXY='*/fortune'
            > ! go get rsc.io/fortune # does not exist in real world, only on test proxy
            [stderr]
            go get rsc.io/fortune: unrecognized import path "rsc.io/fortune": reading https://rsc.io/fortune?go-get=1: 503 Service Unavailable
            [exit status 1]
            > stderr 'git ls-remote'
            FAIL: testdata/script/mod_gonoproxy.txt:27: no match for `(?m)git ls-remote` found in stderr
            
    --- FAIL: TestScript/mod_download_hash (0.31s)
        script_test.go:193: 
            # Testing mod download with non semantic versions; turn off proxy. (0.307s)
            > [!net] skip
            > [!exec:git] skip
            > env GOPROXY=direct
            > env GOSUMDB=off
            > go mod download rsc.io/quote@a91498bed0a73d4bb9c1fb2597925f7883bc40a7
            [stderr]
            rsc.io/quote@a91498bed0a73d4bb9c1fb2597925f7883bc40a7: unrecognized import path "rsc.io/quote": reading https://rsc.io/quote?go-get=1: 503 Service Unavailable
            [exit status 1]
            FAIL: testdata/script/mod_download_hash.txt:9: unexpected command failure
            
    --- FAIL: TestScript/mod_sumdb_golang (0.27s)
        script_test.go:193: 
            # Test default GOPROXY and GOSUMDB (0.083s)
            # download direct from github (0.190s)
            > [!net] skip
            > [!exec:git] skip
            > env GOSUMDB=sum.golang.org
            > env GOPROXY=direct
            > go get -d rsc.io/[email protected]
            [stderr]
            go get rsc.io/[email protected]: unrecognized import path "rsc.io/quote": reading https://rsc.io/quote?go-get=1: 503 Service Unavailable
            [exit status 1]
            FAIL: testdata/script/mod_sumdb_golang.txt:17: unexpected command failure
            
    --- FAIL: TestScript/gopath_moved_repo (0.87s)
        script_test.go:193: 
            # Test that 'go get -u' reports packages whose VCS configurations do not
            # match their import paths. (0.000s)
            # We need to execute a custom Go program to break the config files.
            #
            # git will ask for a username and password when we run 'go get -d -f -u',
            # so we also need to set GIT_ASKPASS. Conveniently, a single binary can
            # perform both tasks! (0.674s)
            # Test that 'go get -u' reports moved git packages. (0.191s)
            > [exec:git] go get -d rsc.io/pdf
            [stderr]
            unrecognized import path "rsc.io/pdf": reading https://rsc.io/pdf?go-get=1: 503 Service Unavailable
            [exit status 1]
            FAIL: testdata/script/gopath_moved_repo.txt:21: unexpected command failure
            
--- FAIL: TestIssue11457 (0.20s)
    go_test.go:1087: running testgo [get -d -u rsc.io/go-get-issue-11457]
    go_test.go:1087: standard error:
    go_test.go:1087: unrecognized import path "rsc.io/go-get-issue-11457": reading https://rsc.io/go-get-issue-11457?go-get=1: 503 Service Unavailable
        
    go_test.go:1087: go [get -d -u rsc.io/go-get-issue-11457] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1
--- FAIL: TestIssue16471 (1.31s)
    go_test.go:1071: git standard error:
    go_test.go:1071: Cloning into 'go-get-issue-10952'...
        
    go_test.go:1072: running testgo [get -u rsc.io/go-get-issue-10952]
    go_test.go:1072: testgo succeeded unexpectedly
FAIL
FAIL	cmd/go	132.219s
FAIL

--- FAIL: TestCodeRepo (11.97s)
    --- FAIL: TestCodeRepo/parallel (0.00s)
        --- FAIL: TestCodeRepo/parallel/swtch.com_testmod/v1.0.0 (0.14s)
            coderepo_test.go:451: Lookup("swtch.com/testmod"): unrecognized import path "swtch.com/testmod": reading https://swtch.com/testmod?go-get=1: 503 Service Unavailable
--- FAIL: TestCodeRepoVersions (1.58s)
    --- FAIL: TestCodeRepoVersions/parallel (0.00s)
        --- FAIL: TestCodeRepoVersions/parallel/swtch.com_testmod (0.00s)
            coderepo_test.go:690: Lookup("swtch.com/testmod"): unrecognized import path "swtch.com/testmod": reading https://swtch.com/testmod?go-get=1: 503 Service Unavailable
--- FAIL: TestLatest (0.47s)
    --- FAIL: TestLatest/parallel (0.00s)
        --- FAIL: TestLatest/parallel/swtch.com_testmod (0.00s)
            coderepo_test.go:768: Lookup("swtch.com/testmod"): unrecognized import path "swtch.com/testmod": reading https://swtch.com/testmod?go-get=1: 503 Service Unavailable
FAIL
FAIL	cmd/go/internal/modfetch	14.044s

--- FAIL: TestGoGetInsecure (1.44s)
    --- FAIL: TestGoGetInsecure/gopath (0.13s)
        go_test.go:2895: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2895: standard error:
        go_test.go:2895: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
            
        go_test.go:2895: testgo failed as expected: exit status 1
        go_test.go:2898: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2898: standard error:
        go_test.go:2898: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
            
        go_test.go:2898: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1
    --- FAIL: TestGoGetInsecure/modules (1.30s)
        go_test.go:2895: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2895: standard error:
        go_test.go:2895: go get insecure.go-get-issue-15410.appspot.com/pkg/p: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
            
        go_test.go:2895: testgo failed as expected: exit status 1
        go_test.go:2898: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:2898: standard error:
        go_test.go:2898: go get insecure.go-get-issue-15410.appspot.com/pkg/p: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
            
        go_test.go:2898: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/tmp/cmd-go-test-772897562/gotest647673300: exit status 1
        panic.go:617: ended in /workdir/tmp/cmd-go-test-772897562/gotest647673300
--- FAIL: TestGoGetInsecureCustomDomain (0.10s)
    go_test.go:2983: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
    go_test.go:2983: standard error:
    go_test.go:2983: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": https fetch: Get "https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1": x509: certificate is valid for *.appspot-preview.com, *.an.r.appspot.com, *.app.google, *.appspot.com, *.as.r.appspot.com, *.de.r.appspot.com, *.df.r.appspot.com, *.dt.r.appspot.com, *.du.r.appspot.com, *.el.r.appspot.com, *.et.r.appspot.com, *.ew.r.appspot.com, *.ey.r.appspot.com, *.ez.r.appspot.com, *.lz.r.appspot.com, *.nn.r.appspot.com, *.nw.r.appspot.com, *.nz.r.appspot.com, *.oa.r.appspot.com, *.rj.r.appspot.com, *.thinkwithgoogle.com, *.ts.r.appspot.com, *.tz.r.appspot.com, *.uc.r.appspot.com, *.ue.r.appspot.com, *.uk.r.appspot.com, *.uw.r.appspot.com, *.withgoogle.com, *.withyoutube.com, *.wl.r.appspot.com, *.wm.r.appspot.com, *.wn.r.appspot.com, app.google, appspot-preview.com, appspot.com, thinkwithgoogle.com, withgoogle.com, withyoutube.com, not insecure.go-get-issue-15410.appspot.com
        
    go_test.go:2983: testgo failed as expected: exit status 1
    go_test.go:2984: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
    go_test.go:2984: standard error:
    go_test.go:2984: unrecognized import path "insecure.go-get-issue-15410.appspot.com/pkg/p": reading https://insecure.go-get-issue-15410.appspot.com/pkg/p?go-get=1: 503 Service Unavailable
        
    go_test.go:2984: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/go/src/cmd/go: exit status 1

@bcmills @matloob @jayconrod Is it in scope for this issue to make those tests not fail if rsc.io, or swtch.com, or insecure.go-get-issue-15410.appspot.com are not available (potentially by moving them to vcs-test.golang.org and insecure.vcs-test.golang.org or so), or is it better to make these separate issues?

bcmills · 2020-07-31T18:04:33Z

@dmitshur, this issue is specifically about TestCodeRepo, so separate issues would probably be good. Ideally, we should resolve these by starting up a test-local server rather than merely moving the tests to vcs-test.golang.org, but that's a lot of work...

dmitshur · 2020-07-31T18:27:11Z

Sounds good. Factored it out into a standalone issue #40519.

ALTree · 2020-10-28T08:27:40Z

longtest builders broken again:
https://build.golang.org/log/f95a05162e528c34983f8d4604d76a6f427f86e6

--- FAIL: TestCodeRepoVersions (1.80s)
    --- FAIL: TestCodeRepoVersions/parallel (0.00s)
        --- FAIL: TestCodeRepoVersions/parallel/gopkg.in_russross_blackfriday.v2 (1.80s)
            coderepo_test.go:684: Versions(""):
                have [v2.0.0 v2.0.1 v2.1.0-pre.1]
                want [v2.0.0 v2.0.1]
FAIL
FAIL	cmd/go/internal/modfetch	17.284s

gopherbot · 2020-10-28T11:09:45Z

Change https://golang.org/cl/265819 mentions this issue: cmd/go/internal/modfetch: update expected tags for TestCodeRepoVersions

Updates #28856 Change-Id: I89c564cefd7c5777904bc00c74617dab693373bf Reviewed-on: https://go-review.googlesource.com/c/go/+/265819 Trust: Tobias Klauser <[email protected]> Run-TryBot: Tobias Klauser <[email protected]> Reviewed-by: Alberto Donizetti <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> TryBot-Result: Go Bot <[email protected]>

gopherbot · 2020-10-28T12:52:03Z

Change https://golang.org/cl/265917 mentions this issue: cmd/go/internal/modfetch: drop gopkg.in/russross/blackfriday.v2 from TestCodeRepoVersions

…TestCodeRepoVersions Follow-up for CL 265819. Given the -pre tag added recently, a new stable version is likely tagged soon. This would break TestCodeRepoVersions on the longtest builders again. Since the other test cases in codeRepoVersionsTests already provide enough coverage, drop gopkg.in/russross/blackfriday.v2 to avoid breaking TestCodeRepoVersions once the release happens. Updates #28856 Change-Id: If86a637b5e47f59faf9048fc1cbbae6e8f1dcc53 Reviewed-on: https://go-review.googlesource.com/c/go/+/265917 Trust: Tobias Klauser <[email protected]> Run-TryBot: Tobias Klauser <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Jay Conrod <[email protected]> TryBot-Result: Go Bot <[email protected]>

gopherbot · 2020-10-28T23:57:07Z

Change https://golang.org/cl/266178 mentions this issue: [release-branch.go1.15] cmd/go/internal/modfetch: drop gopkg.in/russross/blackfriday.v2 from TestCodeRepoVersions

…oss/blackfriday.v2 from TestCodeRepoVersions Follow-up for CL 265819. Given the -pre tag added recently, a new stable version is likely tagged soon. This would break TestCodeRepoVersions on the longtest builders again. Since the other test cases in codeRepoVersionsTests already provide enough coverage, drop gopkg.in/russross/blackfriday.v2 to avoid breaking TestCodeRepoVersions once the release happens. Updates #28856 Change-Id: If86a637b5e47f59faf9048fc1cbbae6e8f1dcc53 Reviewed-on: https://go-review.googlesource.com/c/go/+/265917 Trust: Tobias Klauser <[email protected]> Run-TryBot: Tobias Klauser <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Jay Conrod <[email protected]> TryBot-Result: Go Bot <[email protected]> (cherry picked from commit 421d4e7) Reviewed-on: https://go-review.googlesource.com/c/go/+/266178 Trust: Dmitri Shuralyov <[email protected]> Trust: Jay Conrod <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Tobias Klauser <[email protected]>

gopherbot · 2020-10-29T22:29:23Z

Change https://golang.org/cl/266302 mentions this issue: [release-branch.go1.14] cmd/go/internal/modfetch: drop gopkg.in/russross/blackfriday.v2 from TestCodeRepoVersions

…oss/blackfriday.v2 from TestCodeRepoVersions Follow-up for CL 265819. Given the -pre tag added recently, a new stable version is likely tagged soon. This would break TestCodeRepoVersions on the longtest builders again. Since the other test cases in codeRepoVersionsTests already provide enough coverage, drop gopkg.in/russross/blackfriday.v2 to avoid breaking TestCodeRepoVersions once the release happens. Updates #28856 Change-Id: If86a637b5e47f59faf9048fc1cbbae6e8f1dcc53 Reviewed-on: https://go-review.googlesource.com/c/go/+/265917 Trust: Tobias Klauser <[email protected]> Run-TryBot: Tobias Klauser <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Jay Conrod <[email protected]> TryBot-Result: Go Bot <[email protected]> (cherry picked from commit 421d4e7) Reviewed-on: https://go-review.googlesource.com/c/go/+/266178 Trust: Dmitri Shuralyov <[email protected]> Trust: Jay Conrod <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Tobias Klauser <[email protected]> (cherry picked from commit 8687f6d) Reviewed-on: https://go-review.googlesource.com/c/go/+/266302 Trust: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>

toothrot · 2022-07-20T16:49:03Z

Seen again at https://build.golang.org/log/f1a0e4f0ab66236cb97d5578af05b873d19af60a

--- FAIL: TestCodeRepo (0.00s)
    --- FAIL: TestCodeRepo/vcs-test.golang.org_go_mod_gitrepo1/v2.3.4+incompatible (30.02s)
        coderepo_test.go:599: repoStat("v2.3.4+incompatible"): unrecognized import path "vcs-test.golang.org/go/mod/gitrepo1": https fetch: Get "https://vcs-test.golang.org/go/mod/gitrepo1?go-get=1": dial tcp 35.184.38.56:443: i/o timeout, wanted "resolves to version v2.0.1+incompatible (v2.3.4 is not a tag)"
    --- FAIL: TestCodeRepo/vcs-test.golang.org_go_v2module_v2/v2.0.0 (30.01s)
        coderepo_test.go:603: repo.Stat("v2.0.0"): unrecognized import path "vcs-test.golang.org/go/v2module/v2": https fetch: Get "https://vcs-test.golang.org/go/v2module/v2?go-get=1": dial tcp 35.184.38.56:443: i/o timeout
    --- FAIL: TestCodeRepo/vcs-test.golang.org_go_mod_gitrepo1/master (27.21s)
        coderepo_test.go:603: repo.Stat("master"): unrecognized import path "vcs-test.golang.org/go/mod/gitrepo1": https fetch: Get "https://vcs-test.golang.org/go/mod/gitrepo1?go-get=1": dial tcp 35.184.38.56:443: i/o timeout

bcmills · 2022-07-20T17:17:19Z

The failure in #28856 (comment) doesn't appear to be due to an external code change. Given the i/o timout failure mode, it may be more closely related to #52545.

ALTree added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 18, 2018

ALTree added this to the Go1.12 milestone Nov 18, 2018

andybons changed the title ~~cmd/go: internal/modfetch TestCodeRepo failure~~ cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes Nov 26, 2018

andybons assigned bcmills Nov 26, 2018

andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019

dmitshur mentioned this issue Mar 6, 2019

x/build: restrict outbound network access from builds by default #30612

Closed

bcmills removed the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Mar 7, 2019

bcmills mentioned this issue May 10, 2019

cmd/go/internal/modfetch: TestCodeRepo/parallel/gopkg.in_natefinch_lumberjack.v2/v2.1 failing at head #31965

Closed

andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019

dmitshur assigned dmitshur and unassigned dmitshur Oct 1, 2019

rsc added this to the Backlog milestone Oct 9, 2019

ALTree added the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Nov 5, 2019

dmitshur removed the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Feb 25, 2020

dmitshur mentioned this issue Jul 28, 2020

Packages under rsc.io are no longer available #40452

Closed

dmitshur added the GoCommand cmd/go label Jul 31, 2020

dmitshur mentioned this issue Jul 31, 2020

cmd/go, cmd/go/internal/modfetch: update tests not to rely on external domains that only an individual maintainer has access to #40519

Open

rsc unassigned bcmills Jun 23, 2022

toothrot mentioned this issue Jul 20, 2022

build dashboard triage log #52653

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes #28856

cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes #28856

ALTree commented Nov 18, 2018

josharian commented Nov 18, 2018

andybons commented Nov 26, 2018 •

edited

Loading

andybons commented Nov 26, 2018

dmitshur commented Nov 26, 2018

gopherbot commented Dec 10, 2018

dmitshur commented Mar 6, 2019

bcmills commented Mar 7, 2019

gopherbot commented Mar 21, 2019

ALTree commented Mar 21, 2019

gopherbot commented Oct 1, 2019

andybons commented Oct 1, 2019

ALTree commented Nov 5, 2019

gopherbot commented Nov 5, 2019

gopherbot commented Nov 5, 2019

gopherbot commented Nov 5, 2019

dmitshur commented Feb 25, 2020 •

edited

Loading

dmitshur commented Jul 28, 2020 •

edited

Loading

bcmills commented Jul 31, 2020

dmitshur commented Jul 31, 2020

ALTree commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 29, 2020

toothrot commented Jul 20, 2022

bcmills commented Jul 20, 2022

cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes #28856

cmd/go/internal/modfetch: TestCodeRepo failures due to external repo changes #28856

Comments

ALTree commented Nov 18, 2018

josharian commented Nov 18, 2018

andybons commented Nov 26, 2018 • edited Loading

andybons commented Nov 26, 2018

dmitshur commented Nov 26, 2018

gopherbot commented Dec 10, 2018

dmitshur commented Mar 6, 2019

bcmills commented Mar 7, 2019

gopherbot commented Mar 21, 2019

ALTree commented Mar 21, 2019

gopherbot commented Oct 1, 2019

andybons commented Oct 1, 2019

ALTree commented Nov 5, 2019

gopherbot commented Nov 5, 2019

gopherbot commented Nov 5, 2019

gopherbot commented Nov 5, 2019

dmitshur commented Feb 25, 2020 • edited Loading

dmitshur commented Jul 28, 2020 • edited Loading

bcmills commented Jul 31, 2020

dmitshur commented Jul 31, 2020

ALTree commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 28, 2020

gopherbot commented Oct 29, 2020

toothrot commented Jul 20, 2022

bcmills commented Jul 20, 2022

andybons commented Nov 26, 2018 •

edited

Loading

dmitshur commented Feb 25, 2020 •

edited

Loading

dmitshur commented Jul 28, 2020 •

edited

Loading