-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/mobile: unable to include symbols for App Store submission #28997
Comments
Go 1.10.4 does not cause such problem |
/cc @eliasnaur |
I also has this problem in version 1.11.4 |
What happens if you don't check the "Upload your app's symbols..." checkbox? |
@eliasnaur without checkbox binary gets uploaded and crash logs arrive without symbols |
I am having a similar issue and I use go version go1.11.5 darwin/amd64 |
We just got this issue when migrating to Bazel, so we assumed it was because of that. Apparently it is not. |
Apparently the offending command is:
|
For the record, I have the same issue with Go 1.11.5 darwin/amd64. In the meantime, my current workaround is to strip all debug symbols by passing |
Change https://golang.org/cl/170377 mentions this issue: |
These workarounds predate proper DWARF support and are no longer necessary. Before this patch, running `/usr/bin/symbols go.o` using the object in the c-archive would fail, causing App Store rejections. Fixes #31022 #28997 Change-Id: I6a210b6369c13038777c6e21e874e81afcb50c2f Reviewed-on: https://go-review.googlesource.com/c/go/+/170377 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
This bug has been resolved and I think this issue can be closed. |
@tmm1 how can I try the fix you mention? I've tried the workaround and it still fails: |
You have to compile and use golang from master so it includes 3cb92fc |
I've tried using the latest master and I'm getting the same error. Some things I've checked:
I'm willing to try out any patches or contribute one with some guidance (I don't really know about dwarf symbol tables?) |
@tmm1 I tried to cherry-pick 277609f and 2ae793e on top of Go 1.11.10, and I get a failure at the symbols test:
|
Ok I found out I was missing b56d1ba too |
Can this be closed now? |
I think, no problems on our side anymore. |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
After running
I've did the following:
Exclusion of EasyPGP.framework fixed error message. Previous .framework build (from around5 month ago) works just fine.
What did you expect to see?
Correct build upload
What did you see instead?
Symbol tool failed
error message. At the end of the debug log:The text was updated successfully, but these errors were encountered: