-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.11.4 mod checksum errors #29278
Comments
Perhaps this was because the checksums created by 1.11.3 were the "wrong" ones? So nuking the cache is probably fine? |
No, definitely not 1.11.3, my checksum was made back in August and is broken as of 1.11.4, whereas it worked with 1.11 thru 1.11.3 without showing errors:
|
Yes, pre-1.11.4, modules containing symlinks were constructed erroneously. 1.11.4 correctly omits those symlinks, which may change the sums for a few (hopefully isolated) modules. |
See #27093. |
It sounds like we can close this issue. It's an inconvenient but ultimately benign error caused by previous versions. It can be worked around by manually updating (or simply removing) the appropriate lines from |
Note: if you have a copy of a module with symlinks in your module cache, you likely will need to run |
Should fix the build (broken by go.sum, see golang/go#29278).
* Bump riff dependency to latest * Adjust indirect dependencies and k8s.io/apimachinery to match the changes in riff's Gopkg.lock. * Move k8s.io/apimachinery dependency from indirect to direct group in go.mod. * Redo go.sum based on Go 1.11.4 after `go clean -modcache`. See: - golang/go#29278 - golang/go#29282 * Add go.sum entries for Windows * Make unit tests pass and image relocate work on Windows Fixes https://github.com/pivotal-cf/pfs/issues/175 Fixes https://github.com/pivotal-cf/pfs/issues/135
…on#283) * Remove broken checksums now caught by go 1.11.4 See golang/go#29278 for more info. * Update related MD files * Fix build_binaries docker
Change the offending checksums. See golang/go#29278
* Bump riff dependency to latest * Adjust indirect dependencies and k8s.io/apimachinery to match the changes in riff's Gopkg.lock. * Move k8s.io/apimachinery dependency from indirect to direct group in go.mod. * Redo go.sum based on Go 1.11.4 after `go clean -modcache`. See: - golang/go#29278 - golang/go#29282 * Add go.sum entries for Windows * Make unit tests pass and image relocate work on Windows Fixes https://github.com/pivotal-cf/pfs/issues/175 Fixes https://github.com/pivotal-cf/pfs/issues/135
Go 1.11.3 changed how checksums are created in some cases, which caused failures building via modules. (ref golang/go#29278) Update the checksums for the failing modules. To catch this is the future, a modules build was added to the build matrix. I also noted that we were pinning the `.0` patchlevel of each go version which wouldn't have picked this up, updated it to build with the latest patch release.
$ go version
go version go1.11.4 linux/amd64
$ go get ./...
or
$ go mod download
go: verifying [email protected]+incompatible: checksum mismatch
downloaded: h1:VsBPFP1AI068pPrMxtb/S8Zkgf9xEmTLJjfM+P5UIEo=
go.sum: h1:y0IMTfclpMdsdIbr6uwmJn5/WZ7vFuObxDMdrylFM3A=
Switch to Go 1.11.3
Nuke $GOPATH/pkg/mod/cache
Repeat go get ./... or go mod download, and it works.
I'm creating a simple repo with repro steps now.
The text was updated successfully, but these errors were encountered: