x/tools/go/analysis/internal/checker: TestApplyFixes broken at head

[bcmills]

Lots of breakage showing on https://build.golang.org/?repo=golang.org%2fx%2ftools.

It appears that the tests are ok with release-branch.go1.12, but builds using a go build from head are consistently failing in TestApplyFixes.

Example (https://build.golang.org/log/f7cec2ac4b2787f43974ffa14f8bb2a5929c50ec):

2019/09/11 20:10:38 file=/workdir/tmp/analysistest525415992/src/rename/test.go matched no packages
--- FAIL: TestApplyFixes (0.06s)
    checker_test.go:61: contents of rewritten file
        got: package rename
        
        func Foo() {
        	bar := 12
        	_ = bar
        }
        
        // the end
        
        want: package rename
        
        func Foo() {
        	baz := 12
        	_ = baz
        }
        
        // the end
FAIL
FAIL	golang.org/x/tools/go/analysis/internal/checker	0.080s

From the matched no packages line, I wonder if this was introduced by the fix for #32483.

CC @jayconrod @ianthehat @matloob

[jayconrod]

This reproduces with go1.13.

Bisect in x/tools points to CL 186337 as the first failing commit. @matloob @jirfag please fix or revert. (And please, please run TryBots before merging).

[matloob]

Thanks for finding this. I'm going to revert for now.

[gopherbot]

Change https://golang.org/cl/195061 mentions this issue: go/analysis/internal/checker: set GO111MODULE to off

[gopherbot]

Change https://golang.org/cl/195065 mentions this issue: go/packages: suppress go list -e error when directory outside modules