Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: Cleanup races with Logf and Errorf [1.15 backport] #41034

Closed
gopherbot opened this issue Aug 25, 2020 · 4 comments
Closed

testing: Cleanup races with Logf and Errorf [1.15 backport] #41034

gopherbot opened this issue Aug 25, 2020 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.15.2

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #40908 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport to 1.15. This is a fairly subtle race condition, and the fix is small and contained.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 25, 2020
@gopherbot gopherbot mentioned this issue Aug 25, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.1 milestone Aug 25, 2020
@bcmills
Copy link
Contributor

bcmills commented Aug 25, 2020 •
edited
Loading

This was a regression from Go 1.14.7, which is not affected by the race.

(And that means it is likely that tests written against Go 1.14 will inadvertently trigger the race when run with Go 1.15.)

@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/250617 mentions this issue: [release-branch.go1.15] testing: fix Cleanup race with Logf and Errorf

@cagedmantis
Copy link
Contributor

Approved because this is a critical problem without a workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Aug 27, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 27, 2020
@gopherbot
Copy link
Contributor Author

Closed by merging 45265c2 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Aug 27, 2020
@mlowicki
[release-branch.go1.15] testing: fix Cleanup race with Logf and Errorf
45265c2 
Updates #40908
Fixes #41034

Change-Id: I25561a3f18e730a50e6fbf85aa7bd85bf1b73b6e
Reviewed-on: https://go-review.googlesource.com/c/go/+/250078
Reviewed-by: Tobias Klauser <[email protected]>
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
(cherry picked from commit 00a053b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/250617
Reviewed-by: Emmanuel Odeke <[email protected]>
Reviewed-by: Michał Łowicki <[email protected]>
@dmitshur dmitshur modified the milestones: Go1.15.1, Go1.15.2 Sep 1, 2020
@golang golang locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.15.2
Development

No branches or pull requests
4 participants
@cagedmantis @dmitshur @bcmills @gopherbot