Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/cmd/golangorg: update to newer App Engine runtime when available #51800

Closed
dmitshur opened this issue Mar 18, 2022 · 9 comments
Closed

x/website/cmd/golangorg: update to newer App Engine runtime when available #51800

dmitshur opened this issue Mar 18, 2022 · 9 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

golangorg currently runs in App Engine using the go116 runtime:

https://cs.opensource.google/go/x/website/+/master:cmd/golangorg/app.yaml;l=5;drc=a3cb3101adbb8f1454ce7b15a56fe7e8f11fd640

Since Go 1.16 is no longer supported per Go policy, TryBots that test CLs in x/website will not catch a Go 1.16-only problem. We can help this in the meantime by also testing with Go 1.16.15 explicitly.

This is the tracking issue to update it when a newer runtime becomes available.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Mar 18, 2022
@dmitshur dmitshur added this to the Unreleased milestone Mar 18, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/393858 mentions this issue: maintner/maintnerd/maintapi: test x/website with Go 1.16 longer

gopherbot pushed a commit to golang/build that referenced this issue Mar 23, 2022
@dmitshur @gopherbot
maintner/maintnerd/maintapi: test x/website with Go 1.16 longer
a429dc1 
Provide TryBot test coverage in x/website using Go 1.16
while that version is still used during its deployment.

For golang/go#51800.

Change-Id: I4b1361537a8af8322ec62c86891de46143758c4e
Reviewed-on: https://go-review.googlesource.com/c/build/+/393858
Trust: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
@bcmills
Copy link
Contributor

bcmills commented Dec 9, 2022 •
edited
Loading

According to https://cloud.google.com/appengine/docs/standard/go/runtime, the App Engine runtime now has 1.18 and 1.19 support in preview.

In the meantime, golang.org/x/sys/unix no longer supports Go 1.16 as of https://go.dev/cl/428515, and a recent x/sys/unix is required in order for the x/website repo to build on the riscv64 builders (#57217).

Can this update be prioritized?

(attn @golang/release)

@bcmills bcmills mentioned this issue Dec 9, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/456655 mentions this issue: dashboard: skip x/website on freebsd/riscv64

gopherbot pushed a commit to golang/build that referenced this issue Dec 9, 2022
@gopherbot
dashboard: skip x/website on freebsd/riscv64
61e6a7f 
Updates golang/go#51800.
Updates golang/go#57217.

Change-Id: I9049457e8e69e4f6c35810998bbff2f8371078e1
Reviewed-on: https://go-review.googlesource.com/c/build/+/456655
Reviewed-by: Michael Pratt <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
@dmitshur
Copy link
Contributor Author

dmitshur commented Dec 9, 2022

I think x/website is generally owned by the tools team, not release team, by now.
We still maintain the download server and release history pages (e.g., internal/dl, internal/history), but this isn't relevant to that.

CC @golang/tools-team, @rsc.

@bcmills bcmills added website and removed Builders x/build issues (builders, bots, dashboards) labels Dec 9, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/456715 mentions this issue: maintner/maintnerd/maintapi: stop testing x/website on Go 1.16

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/456521 mentions this issue: cmd/golangorg: update App Engine runtime to Go 1.19

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/456522 mentions this issue: internal/backport: delete

gopherbot pushed a commit to golang/website that referenced this issue Dec 12, 2022
@dmitshur @gopherbot
cmd/golangorg: update App Engine runtime to Go 1.19
21c8d58 
Now that it's available, start deploying with it.

For golang/go#51800.

Change-Id: I11c4dc131e33f192e9d7ea1fb5a154fc3422dece
Reviewed-on: https://go-review.googlesource.com/c/website/+/456521
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
gopherbot pushed a commit to golang/website that referenced this issue Dec 12, 2022
@dmitshur @gopherbot
internal/backport: delete
a697538 
Now that the deploy happens with Go 1.19, it's viable to start using
these packages from the standard library instead of their backported
temporary copies.

Keeping Go 1.18 happy during its last two months of support requires
a tiny complication in pkgdoc package. An alternative path is to not
drop internal/backport/go/doc and all of its dependencies right away,
but getting to zero backported packages sooner was hard to resist...

For golang/go#51800.

Change-Id: Ieb7a137a033d6b6850dfc019c8c0c767756cc30d
Reviewed-on: https://go-review.googlesource.com/c/website/+/456522
Reviewed-by: Bryan Mills <[email protected]>
TryBot-Bypass: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Dec 12, 2022
@dmitshur @gopherbot
maintner/maintnerd/maintapi: stop testing x/website on Go 1.16
a4dfb26 
Testing x/website on Go 1.16.15 was helpful only until App Engine
started supporting¹ a currently-supported Go version like Go 1.19.

This undoes the change added in CL 393858, to be submitted around
the same time as x/website/cmd/golangorg/app.yaml's runtime value
goes from go116 to go119 or so.

¹ https://cloud.google.com/appengine/docs/standard/go/release-notes#December_07_2022

For golang/go#51800.

Change-Id: I621833060a160abf1fccdeb5b331582651eabc14
Reviewed-on: https://go-review.googlesource.com/c/build/+/456715
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
@dmitshur
Copy link
Contributor Author

dmitshur commented Dec 12, 2022 •
edited
Loading

x/website/cmd/golangorg is updated to deploy with Go 1.19,
and the temporary 1.16 trybot in x/website is removed.

Nothing more to do here.

@dmitshur dmitshur moved this to Done in Go Release Dec 12, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/457555 mentions this issue: dashboard: re-enable x/website on freebsd-riscv64-unmatched

gopherbot pushed a commit to golang/build that referenced this issue Dec 14, 2022
@gopherbot
dashboard: re-enable x/website on freebsd-riscv64-unmatched
ece61b0 
This build should be passing on x/website as of CL 456517.

Updates golang/go#51800.
Updates golang/go#57217.

Change-Id: Iff8b8e6600bf15625e994d6ae398eda170c991dc
Reviewed-on: https://go-review.googlesource.com/c/build/+/457555
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
Reviewed-by: Than McIntosh <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
@golang golang locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot