Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/telemetry/internal/counter: TestRepeatedNew persistently failing on GOOS=wasip1 GOARCH=wasm GOWASIRUNTIME=wasmtime #60971

Closed
dmitshur opened this issue Jun 23, 2023 · 2 comments
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@dmitshur
Copy link
Contributor

From https://build.golang.org/log/8e4e0ca514d9b97b6031241988af5dde617870c9:

2023/06/23 12:28:59 neither $XDG_CONFIG_HOME nor $HOME are defined
--- FAIL: TestRepeatedNew (0.00s)
    counter_test.go:126: GOOS wasip1 GARCH wasm
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x0 addr=0x0 pc=0x0]

goroutine 8 [running]:
testing.tRunner.func1.2({0x1f840, 0x1e3870})
	/workdir/go/src/testing/testing.go:1545 +0x1b
testing.tRunner.func1()
	/workdir/go/src/testing/testing.go:1548 +0x37
panic({0x1f840, 0x1e3870})
	/workdir/go/src/runtime/panic.go:914 +0x2c
golang.org/x/telemetry/internal/counter.close(0x144e280)
	/workdir/gopath/src/golang.org/x/telemetry/internal/counter/counter_test.go:73 +0x8
golang.org/x/telemetry/internal/counter.TestRepeatedNew(0x1401380)
	/workdir/gopath/src/golang.org/x/telemetry/internal/counter/counter_test.go:139 +0x12
testing.tRunner(0x1401380, 0x4ba70)
	/workdir/go/src/testing/testing.go:1595 +0xc
created by testing.(*T).Run in goroutine 1
	/workdir/go/src/testing/testing.go:1648 +0x47
FAIL	golang.org/x/telemetry/internal/counter	2.970s

Notably, this isn't happening on the wazero builder, it's passing.

CC @golang/wasm.

@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-wasm WebAssembly issues telemetry x/telemetry issues labels Jun 23, 2023
@dmitshur dmitshur added this to the Unreleased milestone Jun 23, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/505580 mentions this issue: internal/counter: skip tests on solaris, android, and GOARCH=386

gopherbot pushed a commit to golang/telemetry that referenced this issue Jun 23, 2023
Updates golang/go#60615
Updates golang/go#60692
Updates golang/go#60965
Updates golang/go#60967
Updates golang/go#60968
Updates golang/go#60970
Updates golang/go#60971

Change-Id: Ifb0320c279e91185ab04c3efa6bf20f2c141dbe1
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/505580
Reviewed-by: Jamal Carvalho <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
@hyangah
Copy link
Contributor

hyangah commented Jun 23, 2023

cl/505580 made all tests skip on GOOS=wasip1. The build dashboard shows ok now.

x/telemetry is meant to be used by go tools like go commands and gopls. Currently we don't have a plan to support running these tools there yet.

@hyangah hyangah closed this as completed Jun 23, 2023
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 23, 2023
@golang golang locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants