Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: TestIsGoToolDistGenerated failing as of CL 600436 #68574

Closed
dmitshur opened this issue Jul 24, 2024 · 1 comment
Closed

x/build/cmd/gomote: TestIsGoToolDistGenerated failing as of CL 600436 #68574

dmitshur opened this issue Jul 24, 2024 · 1 comment
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 24, 2024 •
edited
Loading 

=== RUN   TestIsGoToolDistGenerated
    push_test.go:70: Checking generated files in /home/swarming/.swarming/w/ir/x/w/goroot/src/.
    push_test.go:111: src/cmd/cgo/zdefaultcc.go: "// Code generated by go tool dist; DO NOT EDIT.\n"
    push_test.go:111: src/cmd/go/internal/cfg/zdefaultcc.go: "// Code generated by go tool dist; DO NOT EDIT.\n"
    push_test.go:111: src/cmd/internal/objabi/zbootstrap.go: "// Code generated by go tool dist; DO NOT EDIT.\n"
    push_test.go:111: src/go/build/zcgo.go: "// Code generated by go tool dist; DO NOT EDIT.\n"
    push_test.go:111: src/internal/buildcfg/zbootstrap.go: "// Code generated by go tool dist; DO NOT EDIT.\n"
    push_test.go:111: src/internal/runtime/sys/zversion.go: "// Code generated by go tool dist; DO NOT EDIT.\n"
    push_test.go:114: isGoToolDistGenerated("src/internal/runtime/sys/zversion.go") = false; want true
    push_test.go:111: src/time/tzdata/zzipdata.go: "// Code generated by go tool dist; DO NOT EDIT.\n"
--- FAIL: TestIsGoToolDistGenerated (0.08s)

E.g., https://ci.chromium.org/b/8741595463844304049.

An internal runtime package was renamed in CL 600436, and so the list in isGoToolDistGenerated needs to be updated accordingly.
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 24, 2024
@dmitshur dmitshur added this to the Unreleased milestone Jul 24, 2024
@dmitshur dmitshur self-assigned this Jul 24, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 24, 2024
@dmitshur dmitshur mentioned this issue Jul 24, 2024
Open
@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Jul 24, 2024
@dmitshur dmitshur moved this to In Progress in Go Release Jul 24, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/600735 mentions this issue: cmd/gomote: update isGoToolDistGenerated for internal/runtime/sys move

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot