all: user-facing golang.org/x repos need to stay green #11811

rsc · 2015-07-21T23:55:56Z

We need to get the subrepos green consistently for 1.5 and moving forward.

edit 2023-06-23 by @heschi:
Modules that are vendored into the main release, such as net and sys, as well as user-facing libraries like tools and text, must be healthy before a release can be issued. Other modules are out of scope.

The text was updated successfully, but these errors were encountered:

Update golang/go#11811 Change-Id: I3d875acf58a015fa4cae16473a118ac8196b9b44 Reviewed-on: https://go-review.googlesource.com/12789 Reviewed-by: Andrew Gerrand <[email protected]>

gopherbot · 2015-07-29T06:00:55Z

CL https://golang.org/cl/12788 mentions this issue.

gopherbot · 2015-07-29T07:01:02Z

CL https://golang.org/cl/12830 mentions this issue.

Update golang/go#11811 Change-Id: I1f8977cf8eed84936c7c2b568f87abe88f5723f9 Reviewed-on: https://go-review.googlesource.com/12788 Reviewed-by: Brad Fitzpatrick <[email protected]>

gopherbot · 2015-07-29T08:01:02Z

CL https://golang.org/cl/12832 mentions this issue.

gopherbot · 2015-07-29T10:00:41Z

CL https://golang.org/cl/12765 mentions this issue.

Some standard library dependencies have changed (packages and files). Both ExampleConfig_CreateFromFiles and ExampleConfig_Import Output needs to be adjusted. Do that. Update golang/go#11811 Change-Id: I523f2adc1aa46f0932a71ccb23dd7c5a6b07fb27 Reviewed-on: https://go-review.googlesource.com/12832 Reviewed-by: Alan Donovan <[email protected]>

Update golang/go#11811 Change-Id: Ic5f1ea87c88d563b6e0ef2d44042e28a9ea03a03 Reviewed-on: https://go-review.googlesource.com/12830 Reviewed-by: Robert Griesemer <[email protected]>

gopherbot · 2015-07-30T01:00:54Z

CL https://golang.org/cl/12838 mentions this issue.

gopherbot · 2015-07-31T20:01:00Z

CL https://golang.org/cl/13008 mentions this issue.

For golang/go#11811. Change-Id: I130f9608840177cfb7fb9fae30765fcb5aa77411 Reviewed-on: https://go-review.googlesource.com/13008 Reviewed-by: Russ Cox <[email protected]>

gopherbot · 2015-07-31T22:01:05Z

CL https://golang.org/cl/13032 mentions this issue.

gopherbot · 2015-07-31T22:01:07Z

CL https://golang.org/cl/13009 mentions this issue.

This should help on slower machines. For golang/go#11811. Change-Id: Ibb5d5bf0f6cedcda6437ef0ee3fc1f4ba89dab90 Reviewed-on: https://go-review.googlesource.com/13009 Reviewed-by: Ian Lance Taylor <[email protected]>

The output of ExampleConfig_CreateFromFiles and ExampleConfig_Import are different for Windows that for other platforms: They contain internal/syscall/windows packages and unicode/utf16 not present in the output for other platforms. For golang/go#11811. Change-Id: Id391fbeec8123616da86cb68fc3cefcd513b2493 Reviewed-on: https://go-review.googlesource.com/13032 Reviewed-by: Ian Lance Taylor <[email protected]>

Attempt to make build work on Plan 9. For golang/go#11811. Change-Id: I37a5eaef441262342994a8f77c86aa5e120deea7 Reviewed-on: https://go-review.googlesource.com/13033 Reviewed-by: Ian Lance Taylor <[email protected]>

See golang/go#11975. For golang/go#11811. Change-Id: I56ee20cd798bf963afdf3c81c4745f07850f6dcc Reviewed-on: https://go-review.googlesource.com/13034 Reviewed-by: Ian Lance Taylor <[email protected]>

gopherbot · 2015-08-01T03:00:33Z

CL https://golang.org/cl/12916 mentions this issue.

Update golang/go#11811 The increased default concurrency in Go 1.5 showed up a test flake in the TestHostKeyCert test. Under load, when the client provided incorrect data, both sides would race to tear down the connection, which would often lead to the server side, running in its own goroutine to see an unexpected EOF or connection reset. Fix this flake (and the incorrect use of t.Fatalf) by passing the error back to the main goroutine for inspection. This also lets us ignore the expected error in the unsuccessful path Change-Id: I5a95c6d240479e9d537f34177e5ca8023b1b08e9 Reviewed-on: https://go-review.googlesource.com/12916 Reviewed-by: Brad Fitzpatrick <[email protected]>

…empty The builders don't have X. (notably Darwin) Perhaps the Linux ones should. Or some should. Please file a separate bug for that. Somebody else might want to upstream this fix to BurntSushi. Updates golang/go#11811 Change-Id: I6d270a83fc59a3923723b5bfbd0b92057a484a1c Reviewed-on: https://go-review.googlesource.com/12765 Reviewed-by: Nigel Tao <[email protected]>

gopherbot · 2015-08-05T21:00:59Z

CL https://golang.org/cl/13252 mentions this issue.

For golang/go#11811. Fixes golang/go#11927. Change-Id: Ie60c687ba93aaeb6c164413289f474be63e0224f Reviewed-on: https://go-review.googlesource.com/13252 Reviewed-by: Robert Griesemer <[email protected]>

gopherbot · 2015-08-06T00:00:48Z

CL https://golang.org/cl/13268 mentions this issue.

For golang/go#11811. Change-Id: Icf16a2d47fcf2fe0d79dd825ccb851a3d63a660f Reviewed-on: https://go-review.googlesource.com/13268 Reviewed-by: Rob Pike <[email protected]> Reviewed-by: David Crawshaw <[email protected]>

prattmic · 2023-06-14T17:49:57Z

Creating internal-branch.go1.21-vendor branches for the following repos:

arch 40c19ba4a7c5 # v0.3.0
crypto 8e447d8cc585 # v0.10.0
mod 62c7e578f1a7
net f5464ddb689c
sync 93782cc822b6
sys 55b11dcdae81 # v0.9.0
term f6de4a13df88 # v0.9.0
text 2df65d769a9e
tools c6c983054920

cherrymui · 2023-07-17T16:49:23Z

Updated internal-branch.go1.21-vendor branches to the commits for latest merge into the main repo (as of
https://go.dev/cl/509099 )

arch	060bf14d30f8a6b2e19c8aab764c104725b1682f v0.4.0
crypto	2e82bdd1719d8f50d18bbb60acc52accc71330b1 v0.11.1-0.20230711161743-2e82bdd1719d
mod	baa5c2d058db25484c20d76985ba394e73176132 v0.12.0
net	57553cbff16307d5178b250ad301e7b466f9d969 v0.12.1-0.20230712162946-57553cbff163
sync	93782cc822b6b554cb7df40332fd010f0473cbc8 v0.3.0 // UNCHANGED
sys	a1a9c4b846b3a485ba94fede5b50579c7f432759 v0.10.0
term	edd9fb7f4aabf5aa4c7bca2146907778a2af0321 v0.10.0
text	e50348080f29449bcd6808c11400b3d45f08b09d v0.11.0
tool	1ca21856af7bffea38bd16dc62d9d31f4b6b5b86 v0.11.1-0.20230712164437-1ca21856af7b

heschi · 2023-08-04T17:56:01Z

Moving to 1.22.

Update golang/go#11811 The increased default concurrency in Go 1.5 showed up a test flake in the TestHostKeyCert test. Under load, when the client provided incorrect data, both sides would race to tear down the connection, which would often lead to the server side, running in its own goroutine to see an unexpected EOF or connection reset. Fix this flake (and the incorrect use of t.Fatalf) by passing the error back to the main goroutine for inspection. This also lets us ignore the expected error in the unsuccessful path Change-Id: I5a95c6d240479e9d537f34177e5ca8023b1b08e9 Reviewed-on: https://go-review.googlesource.com/12916 Reviewed-by: Brad Fitzpatrick <[email protected]>

dmitshur · 2023-12-01T16:02:23Z

Using-facing x/ repos seem green at this point, with one failure mode in x/tools that is being tracked in #64488.

bcmills · 2024-01-03T14:49:20Z

There are currently two systematic failures affecting user-facing subrepos on first-class ports:

And two that affect only secondary ports:

x/pkgsite/internal/tests/deps: TestCmdPkgsiteDeps failing on js/wasm due to lack of exec support #64942
x/pkgsite/internal/tests/deps: TestCmdPkgsiteDeps failures with exit status 1 #64807

mknyszek · 2024-02-02T18:33:02Z

Looking over https://ci.chromium.org/ui/p/golang (currently hard to do for this task, the x-repo consoles should really be grouped by release; filed #65454), the user-facing x-repos appear to be green for the Go 1.22. Furthermore, the known issues pointed out by @bcmills are all fixed. (There are some infra failures on linux-riscv64 but this is a known issue. I was about to file an issue but it looks like the machine is online again, and passing tests for x-repos on Go 1.22: https://chromium-swarm.appspot.com/bot?id=linux-riscv64-mengzhuo.)

Moving this to Go 1.23.

bcmills · 2024-02-06T14:49:26Z

x/telemetry is currently broken on linux/386 and others (x/telemetry/internal/regtest: test consistently failing on many platforms since CL 560462 #65544)
x/pkgsite is currently broken on windows (x/pkgsite/cmd/pkgsite: tests consistently failing with TempDir RemoveAll cleanup errors on windows as of CL 559615 #65545)

For golang/go#11811. Change-Id: Icf16a2d47fcf2fe0d79dd825ccb851a3d63a660f Reviewed-on: https://go-review.googlesource.com/13268 Reviewed-by: Rob Pike <[email protected]> Reviewed-by: David Crawshaw <[email protected]>

Updates golang/go#11811 Updates golang/go#26531 Change-Id: I9cc7daf551b76c3f06b9dd827c5733513c06895e Reviewed-on: https://go-review.googlesource.com/125816 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Agniva De Sarker <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>

The generated static.go file was missing a license header when it was created in 2013 in CL 12805046. CL 38165 added a license header, using the current year in the template. This causes the static.go file to go "out of date" whenever the year changes. Change the copyright year to be a fixed year when the file was created. This way, the TestStaticIsUpToDate test will stop breaking every year. Updates golang/go#36360 Updates golang/go#11811 Change-Id: If1597b0d93b7eacf23b7de103a6d7e3ca049bb4f Reviewed-on: https://go-review.googlesource.com/c/tools/+/213119 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]>

Update golang/go#11811 The increased default concurrency in Go 1.5 showed up a test flake in the TestHostKeyCert test. Under load, when the client provided incorrect data, both sides would race to tear down the connection, which would often lead to the server side, running in its own goroutine to see an unexpected EOF or connection reset. Fix this flake (and the incorrect use of t.Fatalf) by passing the error back to the main goroutine for inspection. This also lets us ignore the expected error in the unsuccessful path Change-Id: I5a95c6d240479e9d537f34177e5ca8023b1b08e9 Reviewed-on: https://go-review.googlesource.com/12916 Reviewed-by: Brad Fitzpatrick <[email protected]>

dmitshur · 2024-07-24T16:39:29Z

Right now x/build and x/website are red:

Neither of those are blocking Go 1.23 (the current milestone of this recurring issue).

We reviewed this in this week's release weekly. In general, we always prefer to have individual, actionable issues filed whenever a golang.org/x repo isn't green. Such issues can block a given release when appropriate. We have an existing process to review the build dashboard for failures and don't necessarily need this issue in the current major milestone, since it's not actionable most of the time.

We agreed to keep it open for now, as a reminder and a tracking issue, but move it to Unreleased milestone.

rsc added this to the Go1.5 milestone Jul 21, 2015

This was referenced Jul 29, 2015

x/tools/go/loader: broken tests #11920

Closed

x/image/draw: TestFastPaths fails on Go 1.4 #11921

Closed

x/tools/go/loader: tests fail with go 1.5 tip #11902

Closed

cmd/compile: internal compiler error: out of fixed registers on 386 #11917

Closed

bradfitz mentioned this issue Jul 30, 2015

x/text: tests fail with 1.4 #11927

Closed

bcmills mentioned this issue Apr 13, 2023

x/crypto/ssh: TestValidTerminalMode fails with some shells #38037

Closed

dmitshur mentioned this issue Jun 23, 2023

x/telemetry/internal/counter: persistent test failures with "fatal error: fault" on windows/386 using Go 1.20 #60965

Closed

heschi changed the title ~~all: golang.org/x repos need to stay green~~ all: user-facing golang.org/x repos need to stay green Jun 23, 2023

heschi modified the milestones: Go1.21, Go1.22 Aug 4, 2023

dmitshur added the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Dec 1, 2023

joedian removed the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Dec 18, 2023

bcmills mentioned this issue Jan 3, 2024

x/exp/protoveneer/cmd/protoveneer: TestGeneration failing due to spurious update to copyright year #64941

Closed

mknyszek mentioned this issue Feb 2, 2024

x/build: group x-repo consoles on https://ci.chromium.org/ui/p/golang by Go release #65454

Open

mknyszek modified the milestones: Go1.22, Go1.23 Feb 2, 2024

bcmills mentioned this issue Feb 6, 2024

x/telemetry/internal/regtest: test consistently failing on many platforms since CL 560462 #65544

Closed

dmitshur modified the milestones: Go1.23, Unreleased Jul 24, 2024

dmitshur removed the recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. label Jul 24, 2024

dmitshur removed this from Release Blockers Jul 29, 2024

dmitshur mentioned this issue Sep 6, 2024

x/example/ragserver/ragserver: requires go1.23.0, so go1.22 builders are redundant with go1.23 builders #69332

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: user-facing golang.org/x repos need to stay green #11811

all: user-facing golang.org/x repos need to stay green #11811

rsc commented Jul 21, 2015 •

edited by heschi

Loading

gopherbot commented Jul 29, 2015

gopherbot commented Jul 29, 2015

gopherbot commented Jul 29, 2015

gopherbot commented Jul 29, 2015

gopherbot commented Jul 30, 2015

gopherbot commented Jul 31, 2015

gopherbot commented Jul 31, 2015

gopherbot commented Jul 31, 2015

gopherbot commented Aug 1, 2015

gopherbot commented Aug 5, 2015

gopherbot commented Aug 6, 2015

prattmic commented Jun 14, 2023

cherrymui commented Jul 17, 2023

heschi commented Aug 4, 2023

dmitshur commented Dec 1, 2023

bcmills commented Jan 3, 2024 •

edited

Loading

mknyszek commented Feb 2, 2024

bcmills commented Feb 6, 2024

dmitshur commented Jul 24, 2024

all: user-facing golang.org/x repos need to stay green #11811

all: user-facing golang.org/x repos need to stay green #11811

Comments

rsc commented Jul 21, 2015 • edited by heschi Loading

gopherbot commented Jul 29, 2015

gopherbot commented Jul 29, 2015

gopherbot commented Jul 29, 2015

gopherbot commented Jul 29, 2015

gopherbot commented Jul 30, 2015

gopherbot commented Jul 31, 2015

gopherbot commented Jul 31, 2015

gopherbot commented Jul 31, 2015

gopherbot commented Aug 1, 2015

gopherbot commented Aug 5, 2015

gopherbot commented Aug 6, 2015

prattmic commented Jun 14, 2023

cherrymui commented Jul 17, 2023

heschi commented Aug 4, 2023

dmitshur commented Dec 1, 2023

bcmills commented Jan 3, 2024 • edited Loading

mknyszek commented Feb 2, 2024

bcmills commented Feb 6, 2024

dmitshur commented Jul 24, 2024

rsc commented Jul 21, 2015 •

edited by heschi

Loading

bcmills commented Jan 3, 2024 •

edited

Loading