Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: eliminate bootstrap version maintenance #69238

Closed
findleyr opened this issue Sep 3, 2024 · 4 comments
Closed

x/playground: eliminate bootstrap version maintenance #69238

findleyr opened this issue Sep 3, 2024 · 4 comments
Assignees
@findleyr
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@findleyr
Copy link
Contributor

findleyr commented Sep 3, 2024 •
edited
Loading

Right now, the deployment of the 'tip' version of the Go playground is broken due to the bump in Go bootstrap version (#54265).
https://cs.opensource.google/go/x/playground/+/master:Dockerfile;l=25;drc=6821b5629810defb1ea68149e090b5b86576d7ca

Since we know the latest released version of Go in the deploy stript (via the latestgo helper), we can also use that for bootstrapping the build.
@gopherbot gopherbot added this to the Unreleased milestone Sep 3, 2024
@gabyhelp
Copy link

gabyhelp commented Sep 3, 2024

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/610336 mentions this issue: all: update Go versions in Dockerfiles

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 3, 2024
@findleyr findleyr self-assigned this Sep 3, 2024
gopherbot pushed a commit to golang/playground that referenced this issue Sep 4, 2024
@findleyr
all: update Go versions in Dockerfiles
33740e3 
Now that the Go bootstrap version has been updated, the tip playground
deployment is failing. We need a better long-term fix, but for now just
bump the bootstrap version.

Also update the (very old) Go version in the sandbox Dockerfile.

Updates golang/go#69238

Change-Id: I14f1bc59904d8fd83cac0aca7efc2dc932a2ce64
Reviewed-on: https://go-review.googlesource.com/c/playground/+/610336
Reviewed-by: Tim King <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/610675 mentions this issue: all: use the previous major Go release to bootstrap the build

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 11, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/612455 mentions this issue: deploy: fix incorrect argument in deploy_goprev.json

gopherbot pushed a commit to golang/playground that referenced this issue Sep 11, 2024
@findleyr
deploy: fix incorrect argument in deploy_goprev.json
e948647 
s/--build_arg/build-arg.

Updates golang/go#69238

Change-Id: Idd502f2f01049e2ae65949e6a1ac894cc5feaa2a
Reviewed-on: https://go-review.googlesource.com/c/playground/+/612455
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Robert Findley <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @gopherbot @findleyr @gabyhelp