x/tools/gopls: "file not found for pos = %d (%s)" crash in go/types

[adonovan]

#!stacks
"runtime.gopanic" && "go/types.(*Checker).fileFor:+11"

This stack vD1W8g was reported by telemetry:

// fileFor returns the *ast.File which contains the position pos.
// If there are no files, the result is nil.
// The position must be valid.
func (check *Checker) fileFor(pos token.Pos) *ast.File {
	assert(pos.IsValid())
	// Eval and CheckExpr tests may not have any source files.
	if len(check.files) == 0 {
		return nil
	}
	for _, file := range check.files {
		if file.FileStart <= pos && pos < file.FileEnd {
			return file
		}
	}
	panic(check.sprintf("file not found for pos = %d (%s)", int(pos), check.fset.Position(pos))) // <--- here
}

The root cause is #69477 in go/types.

crash/crash
runtime.gopanic:+69
go/types.(*Checker).handleBailout:+7
go/types.(*Checker).Files.deferwrap1:+0
runtime.gopanic:+50
go/types.(*Checker).fileFor:+11
go/types.(*Checker).allowVersion:+3
go/types.(*Checker).genericExprList:+21
go/types.(*Checker).callExpr:+127
go/types.(*Checker).exprInternal:+357
go/types.(*Checker).rawExpr:+10
go/types.(*Checker).multiExpr:+2
go/types.(*Checker).assignVars:+31
go/types.(*Checker).stmt:+116
go/types.(*Checker).simpleStmt:=99
go/types.(*Checker).stmt:+210
go/types.(*Checker).stmtList:+9
go/types.(*Checker).funcBody:+23

golang.org/x/tools/[email protected] go1.23.0 linux/amd64 vscode (2)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dups: vEHlHQ rRko4w

[gabyhelp]

Related Issues and Documentation

• x/tools/gopls: "could not locate file for primary type checker error" bug reported by telemetry #66765
• x/tools/gopls: automated issue report (crash): file not found for pos = 1 (-) #66790
• x/tools/gopls: "could not compute pos to range for %v: %v" bug (reported by telemetry) #65960
• x/tools/gopls: bug in typeCheckImpl reported by telemetry #64320 (closed)
• x/tools/gopls: "no file for position" bug in Hover > parseFull (reported by telemetry) #64479 (closed)
• x/tools/gopls: crash when primary diagnostics have invalid positions #66731 (closed)
• x/tools/gopls: "type checker error %q outside its Fset" bug reported by telemetry #66766
• x/tools/gopls: crash in signature help on error.Error #63578 (closed)
• x/tools/gopls: crash in go/types.(*Checker).recordTypeAndValue #45002 (closed)
• x/tools/gopls: crash with invalid end token.Pos for analyzers with related information #56270 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[adonovan]

This stack vEHlHQ was reported by telemetry:

crash/crash
runtime.gopanic:+69
go/types.(*Checker).handleBailout:+7
go/types.(*Checker).Files.deferwrap1:+0
runtime.gopanic:+50
go/types.(*Checker).fileFor:+11
go/types.(*Checker).allowVersion:+3
go/types.(*Checker).genericExprList:+21
go/types.(*Checker).callExpr:+127
go/types.(*Checker).exprInternal:+357
go/types.(*Checker).rawExpr:+10
go/types.(*Checker).multiExpr:+2
go/types.(*Checker).initVars:+51
go/types.(*Checker).shortVarDecl:+61
go/types.(*Checker).stmt:+113
go/types.(*Checker).simpleStmt:=99
go/types.(*Checker).stmt:+210
go/types.(*Checker).stmtList:+9

golang.org/x/tools/[email protected] go1.23.0 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

[adonovan]

This stack rRko4w was reported by telemetry:

crash/crash
runtime.gopanic:+69
go/types.(*Checker).handleBailout:+7
go/types.(*Checker).Files.deferwrap1:+0
runtime.gopanic:+50
go/types.(*Checker).fileFor:+11
go/types.(*Checker).allowVersion:+3
go/types.(*Checker).genericExprList:+21
go/types.(*Checker).callExpr:+127
go/types.(*Checker).exprInternal:+357
go/types.(*Checker).rawExpr:+10
go/types.(*Checker).suspendedCall:+4
go/types.(*Checker).stmt:+142
go/types.(*Checker).stmtList:+9
go/types.(*Checker).funcBody:+23
go/types.(*Checker).funcDecl.func1:+1
go/types.(*Checker).processDelayed:+16

golang.org/x/tools/[email protected] go1.23.0 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

[gopherbot]

Change https://go.dev/cl/613735 mentions this issue: go/types: compute effective Go version independent of token.Pos