Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: "could not compute pos to range for %v: %v" bug (reported by telemetry) #65960

Open
adonovan opened this issue Feb 27, 2024 · 5 comments
Open

x/tools/gopls: "could not compute pos to range for %v: %v" bug (reported by telemetry) #65960

adonovan opened this issue Feb 27, 2024 · 5 comments
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.18.0

Comments

@adonovan
Copy link
Member

adonovan commented Feb 27, 2024 •
edited
Loading 

#!stacks
"bug.Reportf" &&
("cache.typeErrorsToDiagnostics.func1:+50" ||
  "cache.typeErrorsToDiagnostics.func1:+80" ||
  "cache.typeErrorsToDiagnostics.func1:+74")

This stack q8FyvQ was reported by telemetry:

Note variants:

  • bug.Reportf("TypeErrorEndPos returned invalid end: %v", err)
  • bug.Reportf("ReadGo116ErrorData returned invalid end: %v", err)
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.typeErrorsToDiagnostics.func1:+50
golang.org/x/tools/gopls/internal/cache.typeErrorsToDiagnostics:+119
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).checkPackage:+127
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).handleSyntaxPackage:+70
golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackageInternal.func2:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0

golang.org/x/tools/[email protected] go1.21.5 darwin/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dups: rnoW6w 7zL2qQ pT-4Ug
@adonovan adonovan added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/telemetry-wins labels Feb 27, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 27, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/567416 mentions this issue: gopls/internal/cache: add debug assertions for bug report

@suzmue suzmue modified the milestones: Unreleased, gopls/v0.15.1 Feb 27, 2024
@findleyr findleyr modified the milestones: gopls/v0.15.1, gopls/v0.16.0 Feb 28, 2024
gopherbot pushed a commit to golang/tools that referenced this issue Feb 28, 2024
@adonovan @gopherbot
gopls/internal/cache: add debug assertions for bug report
1f7dbdf 
Updates golang/go#65960

Change-Id: I01a416a0cf9cf8e13195c0d9405008ded1a9c53a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/567416
Auto-Submit: Alan Donovan <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
This was referenced Apr 10, 2024
Open
Open
@findleyr findleyr modified the milestones: gopls/v0.16.0, gopls/v0.17.0 May 23, 2024
@adonovan
Copy link
Member Author

This stack rnoW6w was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.typeErrorsToDiagnostics.func1:+50
golang.org/x/tools/gopls/internal/cache.typeErrorsToDiagnostics:+122
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).checkPackage:+127
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).handleSyntaxPackage:+70
golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackageInternal.func2:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0

golang.org/x/tools/[email protected] go1.22.2 windows/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

This was referenced Jun 18, 2024
Closed
Open
@gabyhelp gabyhelp mentioned this issue Jun 26, 2024
Closed
@gabyhelp gabyhelp mentioned this issue Aug 9, 2024
Open
@gabyhelp gabyhelp mentioned this issue Sep 7, 2024
Closed
@adonovan
Copy link
Member Author

A new variant:

				// debugging #65960
				if _, err := safetoken.Offset(pgf.Tok, end); err != nil {
					bug.Reportf("ReadGo116ErrorData returned invalid end: %v", err)
				}

@adonovan
Copy link
Member Author

This stack 7zL2qQ was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.0 linux/amd64 other (1)

This stack pT-4Ug was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.0 linux/amd64 other (1)

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/621876 mentions this issue: gopls/internal/cache: refine bug reports

@findleyr findleyr modified the milestones: gopls/v0.17.0, gopls/v0.18.0 Oct 22, 2024
gopherbot pushed a commit to golang/tools that referenced this issue Oct 22, 2024
@findleyr @gopherbot
gopls/internal/cache: refine bug reports
6381f0b 
Refine a few bug reports related to incorrectly positioned type checker
errors, by differentiating the 'fixed file' case from the case with no
fixed files.

Since we haven't made progress on these bugs, we need more information
to guide our debugging.

If the bugs only occur in the presence of AST fixes, we can probably
downgrade them to not be a bug: if we're fixing the AST, we won't
display type checker errors anyway. Nevertheless, leave the bug reports
for now, so that we can collect data.

For golang/go#65960
For golang/go#66765
For golang/go#66766

Change-Id: I2060c897d249cdd5cc3e7bb183d3f563987bec57
Reviewed-on: https://go-review.googlesource.com/c/tools/+/621876
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Alan Donovan <[email protected]>
Auto-Submit: Robert Findley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.18.0
Development

No branches or pull requests
4 participants
@adonovan @suzmue @gopherbot @findleyr