New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove GOROOT custom install instruction #25190

Closed

JoeCortopassi wants to merge 1 commit into golang:master from JoeCortopassi:patch-1

Contributor

JoeCortopassi commented Apr 30, 2018

Setting GOROOT is no longer necessary for custom installation as of 1.10 (reference: https://go-review.googlesource.com/c/go/+/42533). Fixes #25002


          Remove "Setting GOROOT" custom install instruction

156bf65

Setting GOROOT is no longer necessary for custom installation as of 1.10 (https://go-review.googlesource.com/c/go/+/42533)

Link to reporting issue here: #25002

googlebot added the cla: yes label

Contributor

gopherbot commented Apr 30, 2018

This PR (HEAD: 156bf65) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/110435 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Apr 30, 2018

Message from Rodolfo Carvalho:

Patch Set 1:

@JoeCortopassi one caveat before removing the instructions is #23445, godoc is not as smart as the go tool yet.

Assuming that gets fixed in Go 1.11, removing the GOROOT instructions should be fine.

Please don’t reply on this GitHub thread. Visit golang.org/cl/110435.
After addressing review feedback, remember to publish your drafts!

gopherbot force-pushed the master branch 3 times, most recently from 6a8cff5 to 5d9c782 Compare

May 1, 2018 15:59

Contributor

gopherbot commented May 4, 2018

Message from Joe Cortopassi:

Patch Set 1:

Patch Set 1:

@JoeCortopassi one caveat before removing the instructions is #23445, godoc is not as smart as the go tool yet.

Assuming that gets fixed in Go 1.11, removing the GOROOT instructions should be fine.

Should I apply this change elsewhere? Or is this good, and it will go out when 1.11 does?

Please don’t reply on this GitHub thread. Visit golang.org/cl/110435.
After addressing review feedback, remember to publish your drafts!

gopherbot force-pushed the master branch from a8a60ac to 87412a1 Compare

May 6, 2018 04:30

gopherbot force-pushed the master branch 2 times, most recently from e4259d6 to 6dbaf03 Compare

May 31, 2018 18:23

Contributor

gopherbot commented Jun 2, 2018

Message from Agniva De Sarker:

Patch Set 1:

Adding Ian.

Please don’t reply on this GitHub thread. Visit golang.org/cl/110435.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 5, 2018

Message from Ian Lance Taylor:

Patch Set 1:

godoc hasn't been fixed yet, so it seems to me that this change shouldn't go in yet.

Please don’t reply on this GitHub thread. Visit golang.org/cl/110435.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 5, 2018

Message from Agniva De Sarker:

Patch Set 1:

Patch Set 1:

godoc hasn't been fixed yet, so it seems to me that this change shouldn't go in yet.

Ian- I mentioned some ways we can solve the godoc issue in #23445. Would you be able to take a look ?

Please don’t reply on this GitHub thread. Visit golang.org/cl/110435.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 12, 2018

Message from Agniva De Sarker:

Patch Set 1:

Patch Set 1:

godoc hasn't been fixed yet, so it seems to me that this change shouldn't go in yet.

Ian- godoc issue has been fixed now.

Please don’t reply on this GitHub thread. Visit golang.org/cl/110435.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 12, 2018

Message from Ian Lance Taylor:

Patch Set 1: Code-Review+2

Thanks!

Please don’t reply on this GitHub thread. Visit golang.org/cl/110435.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 12, 2018

This PR is being closed because golang.org/cl/110435 has been merged.

gopherbot closed this

gopherbot pushed a commit that referenced this pull request


          doc: remove GOROOT custom install instruction

6b3e343

Setting GOROOT is no longer necessary for custom installation as of 1.10 (reference: https://go-review.googlesource.com/c/go/+/42533). Fixes #25002

Change-Id: Ic3980833ac437b7a20b951df33805ad1071a40ce
GitHub-Last-Rev: 156bf65
GitHub-Pull-Request: #25190
Reviewed-on: https://go-review.googlesource.com/110435
Reviewed-by: Ian Lance Taylor <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels